Guest test executor refactoring #151
Conversation
refactoring guest.test_executor into $FEATURE based general implementation, distribute $TESTCASE based feature level test_execution to $FEATURE/$FEATURE.test_executor.sh [Test Components] tdx [Test Types] any [Supported Devices] spr,emr,gnr,srf Signed-off-by: Hongyu Ning <[email protected]>
|
Hi @ysun , would you help on this guest-test code architecture refactoring review, it's done based on Rex Zhang's new guest-test feature adding proposal, hopefully we could support new features being added easily and clearly from more contributors like Rex start from this new refactoring done. |
Sure, sorry I missed this PR. I'll do it ASAP. |
guest-test/guest.test_executor.sh
Outdated
| SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )" | ||
| echo "$SCRIPT_DIR" | ||
| else # bypass above execution in case of being sourced | ||
| ehco "guest.test_executor.sh being sourced" |
guest-test/guest.test_executor.sh
Outdated
| echo "$SCRIPT_DIR" | ||
| # exec only if script being executed | ||
| if [ "${BASH_SOURCE[0]}" -ef "$0" ]; then | ||
| SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )" |
There was a problem hiding this comment.
Hi, are the quotation marks really necessary? Or is it for coding style checking?
Why not SCRIPT_DIR=$( cd $( dirname "$0" ) && pwd ) ?
|
|
||
| ###################### Variables ###################### | ||
| ## common variables example ## | ||
| SCRIPT_DIR_LOCAL="$( cd "$( dirname "$0" )" && pwd )" |
There was a problem hiding this comment.
The same question as the previous one about the quotation marks.
|
|
||
| ###################### Do Works ###################### | ||
| ## common works example ## | ||
| cd "$(dirname "$0")" 2>/dev/null || exit 1 |
There was a problem hiding this comment.
That's my concern about the quote marks, what do you really want to quote? Here are "$(dirname " and ")". Are they correct?
update previous osv_sanity implementation reference based on test_executor refactoring [Test Components] tdx [Test Types] func [Supported Devices] spr,emr,gnr,srf Signed-off-by: Hongyu Ning <[email protected]>
hongyuni
force-pushed
the
guest_test_executor_refactoring
branch
2 times, most recently
from
a360f20 to
3441275
Compare
|
Thank Hongyu for the quick response! |
No description provided.