add 4 guest test td attestation TCs and improve overall test logic #124
Conversation
|
the remained CodeCheck failure are related to source code ported from linux kernel tools/testing/selftests/tdx/, maybe we would keep them the way it is to avoid too much differences compared to linux kernel selftests code implementation |
| @@ -282,6 +284,7 @@ if ! guest_kernel_check; then | |||
| pkill "${VM_TYPE}vm_$PORT" | |||
| die "TEST TIMEOUT!!!!!!!!!!!!" | |||
| elif [ "$GCOV" == "off" ] && [ "$EXEC_FLAG" -eq 1 ]; then | |||
| pkill "${VM_TYPE}vm_$PORT" | |||
There was a problem hiding this comment.
Hi Yongyu,
You mixed 'tabs' and 'spaces' for the indentation in the whole file.
Would you like to fix it?
There was a problem hiding this comment.
fixed in new commit
guest-test/tdx/tdx_attest_check.sh
Outdated
| source common.sh | ||
|
|
||
| while getopts :t: arg; do | ||
| case $arg in |
There was a problem hiding this comment.
Please use 2 spaces for each indentation level instead of tabs in shell files.
It would be great if you could fix the indentation for the whole file.
Great thanks.
There was a problem hiding this comment.
fixed in new commit
There was a problem hiding this comment.
Please use 2 spaces for each indentation level instead of tabs in shell files. It would be great if you could fix the indentation for the whole file. Great thanks.
@hongyuni Hi Hongyu, as mentioned, please use 2 spaces for the indentation. @hanning0511 Please correct me if I'm wrong. I remember that we have such rules, right?
There was a problem hiding this comment.
There was a problem hiding this comment.
sorry, updated 2 spaces indentation in latest commit, thought do so but there was some mistake. Would you help to review it?
| @@ -0,0 +1,319 @@ | |||
| /* SPDX-License-Identifier: GPL-2.0 */ | |||
| /* | |||
| * kselftest.h: low-level kselftest framework to include from | |||
There was a problem hiding this comment.
Let's have a talk about why need these header files.
There was a problem hiding this comment.
above source header files are all from kselftest
|
Hi @ysun, all tab/2 spaces mismatching issues fixed in latest commit, would you take a new review? |
strict on the $BOOT_PATTERN to avoid fake guest test execution [Test Components] tdx [Test Types] any [Supported Devices] spr,emr,gnr,srf Signed-off-by: Hongyu Ning <[email protected]>
add new implementation of 4 tdx guest attestation related testcases [Test Components] tdx [Test Types] func [Supported Devices] spr,emr,gnr,srf Signed-off-by: Hongyu Ning <[email protected]>
add tdx_guest_attest compile tools prepare logic to support auto compile in centos stream 9 or rhel 9 guest os [Test Components] tdx [Test Types] func [Supported Devices] spr,emr,gnr,srf Signed-off-by: Hongyu Ning <[email protected]>
improve test_launcher management logic to support well on $GCOV=on case and several corner VM lifecycle management issues [Test Components] tdx [Test Types] any [Supported Devices] spr,emr,gnr,srf Signed-off-by: Hongyu Ning <[email protected]>
improve code logic based on code check hints [Test Components] tdx [Test Types] func [Supported Devices] spr,emr,gnr,srf Signed-off-by: Hongyu Ning <[email protected]>
use guest os installed kernel headers search path and remove previous standalone header file to avoid kernel driver and selftest tool ioctl conflictions [Test Components] tdx [Test Types] func [Supported Devices] spr,emr,gnr,srf Signed-off-by: Hongyu Ning <[email protected]>
hongyuni
force-pushed
the
guest_test_td_attest
branch
from
1ffd1d9 to
2d63a3c
Compare
guest-test/tdx/tdx_attest_check.sh
Outdated
| @@ -8,77 +8,77 @@ | |||
|
|
|||
|
|
|||
| # @desc This script do basic TD attestation check in TDX Guest VM | |||
| # test binary is based on kselftest linux/tools/testing/selftests/tdx implementation | |||
| # test binary is based on kselftest linux/tools/testing/selftests/tdx implementation | |||
There was a problem hiding this comment.
The indentation is not correct here.
And you don't need to add new commits to fix this. Update the patch and force-update the branch in your own remote repo. The PR can be updated automatically.
There was a problem hiding this comment.
Others look good to me.
Next time, please refine the patch right in the patch instead of adding new ones.
There was a problem hiding this comment.
sorry for that, I've revised it based on your comments.
and got your point, will keep the PR consistent in future.
all tab format unified to 2 spaces across all source code [Test Components] tdx [Test Types] func [Supported Devices] spr,emr,gnr.srf Signed-off-by: Hongyu Ning <[email protected]>
hongyuni
force-pushed
the
guest_test_td_attest
branch
2 times, most recently
from
77dbc9f to
3482060
Compare
add 4 guest test td attestation TCs and improve overall test logic, includes test_executor and test_launcher logic improvement