ifs: improve the other dependence check point and reason description

Improve the other dependence check point and reason description, and no need dump csv file for ifs bach loading test case. Signed-off-by: Pengfei Xu <[email protected]>
intel · Apr 26, 2024 · fdf08a7 · fdf08a7
1 parent 5347be2
commit fdf08a7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ifs/ifs_tests.sh b/ifs/ifs_tests.sh
@@ -5,8 +5,9 @@
 # Description: Test script to verify Intel IFS(In Field SCAN) functionality
 
 cd "$(dirname "$0")" 2>/dev/null || exit 1
+# shellcheck source=/dev/null
 source ../.env
-
+# shellcheck source=/dev/null
 source "ifs_common.sh"
 
 basic_usage() {
@@ -56,7 +57,6 @@ run_ifs_tests() {
       check_file_content "${IFS_PATH}/${BATCH}" "none" "$CONTAIN"
       check_file_content "${IFS_PATH}/${VERSION}" "none" "$CONTAIN"
       init_log "$NAME"
-      dump_ifs_test "$NAME"
       ;;
     ifs_batch)
       modprobe -r "$IFS_NAME"
@@ -70,9 +70,9 @@ run_ifs_tests() {
         check_file_content "${IFS_PATH}/${VERSION}" "none" "$NE"
       else
         test_print_wrg "No ${IFS_PATH}/${BATCH} file, is it 5.15 or old ifs kernel?"
+        return 2
       fi
       init_log "$NAME"
-      dump_ifs_test "$NAME"
       ;;
     "$IMG_VERSION")
       modprobe -r "$IFS_NAME"

diff --git a/ifs/tests b/ifs/tests
@@ -2,7 +2,7 @@
 # Intel® Architecture-based platforms.
 # @hw_dep:
 # @other_dep: general_test.sh -t kconfig -k "CONFIG_INTEL_IFS=m"
-# @other_warn: general_test.sh -t dmesg -p "contain" -k "sgx_init&returned 0" @ check if SGX is enabled in BIOS as IFS relies on enabled SGX
+# @other_warn: ifs_tests.sh -m 0 -p all -b 1 -n ifs_batch @ check if SGX init ok and DIMM proper set as IFS relies on enabled SGX
 # ifs_0 scan test cases, it works on SPR(Sapphire Rapids) platform and future server
 ifs_tests.sh -m 0 -p all -n load_ifs
 ifs_tests.sh -m 0 -p all -b 1 -n ifs_batch