Fix lkp picking up system's perf and Add new param #388
Conversation
|
@Suneeth-D please update the param thp_opt in |
Suneeth-D
force-pushed
the
perf-bench-numa-mem
branch
from
3621deb to
86b42fe
Compare
programs/perf-bench-numa-mem/run
Outdated
| perf_path=/lkp/benchmarks/perf/perf | ||
| else | ||
| perf_path=/usr/bin/perf | ||
| fi |
There was a problem hiding this comment.
thanks, for above lines, how about using set_perf_path "/lkp/benchmarks/perf/perf" like others? And the later call of perf can also changed to $perf.
There was a problem hiding this comment.
Thanks for your review, tried the same and it's working good. I have also pushed the changes.
There was a problem hiding this comment.
got it, and may need one more change that actually the whole if/else/fi can be replaced by one set_perf_path "/lkp/benchmarks/perf/perf", which will decide to use "/lkp/benchmarks/perf/perf" or /usr/bin/perf inside.
There was a problem hiding this comment.
Changed that and tested the same both the cases ("/lkp/benchmarks/perf/perf" and "/usr/bin/perf inside.") are working fine. Thanks.
Suneeth-D
force-pushed
the
perf-bench-numa-mem
branch
from
86b42fe to
ab2da70
Compare
1) Fix: lkp unable to pick latest perf rather using system's perf as a consequence unable to run benchmarks on custom kernels 2) Feat: add new parameter # -thp_opt to enable lkp run two different variant of the microbenchmark (thp/no_thp) and lkp ncompare able to differentiate the results of the same Reviewed-by: Srikanth Aithal <[email protected]> Signed-off-by: Suneeth D <[email protected]>
Suneeth-D
force-pushed
the
perf-bench-numa-mem
branch
from
ab2da70 to
6e66c19
Compare
|
thanks for the patch |
consequence unable to run benchmarks on custom kernels
variant of the microbenchmark (thp/no_thp) and lkp ncompare able to
differentiate the results of the same
Reviewed-by: Srikanth Aithal [email protected]