h26xparser: Fix build error with GCC9 #876

saininav · 2019-06-03T06:48:01Z

GCC9 causing build failure:

| ../../git/codecparsers/h264Parser.cpp: In constructor 'YamiParser::H264::PPS::PPS()':
| ../../git/codecparsers/h264Parser.cpp:140:41: error: 'void* memset(void*, int, size_t)' clearing an object of type 'struct YamiParser::H264::PPS' with no trivial copy-assignment; use assignment or value-initialization instead [-Werror=class-memaccess]
| 140 | memset(this, 0, offsetof(PPS, m_sps));
| | ^
| In file included from ../../git/codecparsers/h264Parser.cpp:21:
| ../../git/codecparsers/h264Parser.h:292:8: note: 'struct YamiParser::H264::PPS' declared here
| 292 | struct PPS {
| | ^~~
| ../../git/codecparsers/h264Parser.cpp: In constructor 'YamiParser::H264::SliceHeader::SliceHeader()':
| ../../git/codecparsers/h264Parser.cpp:686:49: error: 'void* memset(void*, int, size_t)' clearing an object of type 'class YamiParser::H264::SliceHeader' with no trivial copy-assignment; use assignment or value-initialization instead [-Werror=class-memaccess]
| 686 | memset(this, 0, offsetof(SliceHeader, m_pps));
| | ^
| In file included from ../../git/codecparsers/h264Parser.cpp:21:
| ../../git/codecparsers/h264Parser.h:371:7: note: 'class YamiParser::H264::SliceHeader' declared here
| 371 | class SliceHeader {
| | ^~~~~~~~~~~
| ../../git/codecparsers/h265Parser.cpp: In constructor 'YamiParser::H265::VPS::VPS()':
| ../../git/codecparsers/h265Parser.cpp:165:53: error: 'void* memset(void*, int, size_t)' clearing an object of type 'struct YamiParser::H265::VPS' with no trivial copy-assignment; use assignment or value-initialization instead [-Werror=class-memaccess]
| 165 | memset(this, 0, offsetof(VPS, hrd_layer_set_idx));
| | ^
| In file included from ../../git/codecparsers/h265Parser.cpp:21:
| ../../git/codecparsers/h265Parser.h:256:12: note: 'struct YamiParser::H265::VPS' declared here
| 256 | struct VPS {
| | ^~~
| ../../git/codecparsers/h265Parser.cpp: In constructor 'YamiParser::H265::SPS::SPS()':
| ../../git/codecparsers/h265Parser.cpp:174:39: error: 'void* memset(void*, int, size_t)' clearing an object of type 'struct YamiParser::H265::SPS' with no trivial copy-assignment; use assignment or value-initialization instead [-Werror=class-memaccess]
| 174 | memset(this, 0, offsetof(SPS, vps));
| | ^
| In file included from ../../git/codecparsers/h265Parser.cpp:21:
| ../../git/codecparsers/h265Parser.h:290:12: note: 'struct YamiParser::H265::SPS' declared here
| 290 | struct SPS {
| | ^~~
| ../../git/codecparsers/h265Parser.cpp: In constructor 'YamiParser::H265::PPS::PPS()':
| ../../git/codecparsers/h265Parser.cpp:179:39: error: 'void* memset(void*, int, size_t)' clearing an object of type 'struct YamiParser::H265::PPS' with no trivial copy-assignment; use assignment or value-initialization instead [-Werror=class-memaccess]
| 179 | memset(this, 0, offsetof(PPS, sps));
| | ^
| In file included from ../../git/codecparsers/h265Parser.cpp:21:
| ../../git/codecparsers/h265Parser.h:362:12: note: 'struct YamiParser::H265::PPS' declared here
| 362 | struct PPS {
| | ^~~
| ../../git/codecparsers/h265Parser.cpp: In constructor 'YamiParser::H265::SliceHeader::SliceHeader()':
| ../../git/codecparsers/h265Parser.cpp:184:47: error: 'void* memset(void*, int, size_t)' clearing an object of type 'struct YamiParser::H265::SliceHeader' with no trivial copy-assignment; use assignment or value-initialization instead [-Werror=class-memaccess]
| 184 | memset(this, 0, offsetof(SliceHeader, pps));
| | ^
| In file included from ../../git/codecparsers/h265Parser.cpp:21:
| ../../git/codecparsers/h265Parser.h:499:12: note: 'struct YamiParser::H265::SliceHeader' declared here
| 499 | struct SliceHeader {
| | ^~~~~~~~~~~
| cc1plus: all warnings being treated as errors

By typecasting structure pointer to void pointer, GCC9 does normal memset operation where offsetof() give correct
number of bytes to set.

Signed-off-by: Naveen Saini [email protected]

xuguangxin · 2019-06-03T07:21:33Z

@saininav thanks for your patch. It's very helpful.
I think it will fix #875 too.
Could you help with it too?
Full configuration can be enabled by

autogen.sh --enable-h264enc --enable-jpegenc --enable-vp8enc --enable-vp9enc --enable-h265enc --enable-mpeg2dec --enable-vp8dec --enable-vp9dec --enable-jpegdec --enable-h264dec --enable-h265dec --enable-vc1dec --enable-v4l2 --enable-tests

thanks for help.

xuguangxin · 2019-06-10T02:41:03Z

codecparsers/mpeg2_parser.cpp

@@ -173,7 +173,7 @@ namespace MPEG2 {

    SeqExtension::SeqExtension() { memset(this, 0, sizeof(*this)); }

-    SeqHeader::SeqHeader() { memset(this, 0, sizeof(*this)); }
+    SeqHeader::SeqHeader() { memset((void*)this, 0, sizeof(*this)); }


if we need this, why we do not need to add the same thing for SeqExtension?

Thanks for your review. GCC9 feels uneasy with non-trival classes.

but SeqExtension has constructor like SeqHeader, right?
thanks

I believe definition of Trivial class includes not only constructors but also operators, destructors, data members, functions, baseclass. All these should be trivial in order to define a class trivial.

useful link:
https://stackoverflow.com/questions/30096911/which-rules-determine-whether-an-object-is-trivially-copyable

From a quick view, I can say SeqExtension has no user defined members, but this is not the case with SeqHeader.

struct SeqHeader { SeqHeader(); uint32_t horizontal_size_value; uint32_t vertical_size_value; uint32_t aspect_ratio_info; uint32_t frame_rate_code; uint32_t bit_rate_value; bool marker_bit; uint32_t vbv_buffer_size_value; bool constrained_params_flag; QuantMatrices quantizationMatrices; };

You are right. SeqHeader has the quantizationMatrices, the memset will override the value set in QuantMatrices().
Could you help change it to

SeqHeader::SeqHeader() { memset((void*)this, 0, offsetof(SeqHeader, quantizationMatrices)); }

thanks

xuguangxin · 2019-06-10T02:42:11Z

@saininav , thanks for the update.
looks pretty. Just one questions listed above

thanks

xuguangxin

@saininav thanks for your great help.
Will merge it after we did some regression test.

xuguangxin · 2019-06-11T04:02:17Z

@saininav , seems CI build failed,
you may need
#include <cstddef>

https://travis-ci.org/intel/libyami/builds/544025956#L1433

thanks

GCC9 causing build failure: | ../../git/codecparsers/h264Parser.cpp: In constructor 'YamiParser::H264::PPS::PPS()': | ../../git/codecparsers/h264Parser.cpp:140:41: error: 'void* memset(void*, int, size_t)' clearing an object of type 'struct YamiParser::H264::PPS' with no trivial copy-assignment; use assignment or value-initialization instead [-Werror=class-memaccess] | 140 | memset(this, 0, offsetof(PPS, m_sps)); | | ^ | In file included from ../../git/codecparsers/h264Parser.cpp:21: | ../../git/codecparsers/h264Parser.h:292:8: note: 'struct YamiParser::H264::PPS' declared here | 292 | struct PPS { | | ^~~ | ../../git/codecparsers/h264Parser.cpp: In constructor 'YamiParser::H264::SliceHeader::SliceHeader()': | ../../git/codecparsers/h264Parser.cpp:686:49: error: 'void* memset(void*, int, size_t)' clearing an object of type 'class YamiParser::H264::SliceHeader' with no trivial copy-assignment; use assignment or value-initialization instead [-Werror=class-memaccess] | 686 | memset(this, 0, offsetof(SliceHeader, m_pps)); | | ^ | In file included from ../../git/codecparsers/h264Parser.cpp:21: | ../../git/codecparsers/h264Parser.h:371:7: note: 'class YamiParser::H264::SliceHeader' declared here | 371 | class SliceHeader { | | ^~~~~~~~~~~ | ../../git/codecparsers/h265Parser.cpp: In constructor 'YamiParser::H265::VPS::VPS()': | ../../git/codecparsers/h265Parser.cpp:165:53: error: 'void* memset(void*, int, size_t)' clearing an object of type 'struct YamiParser::H265::VPS' with no trivial copy-assignment; use assignment or value-initialization instead [-Werror=class-memaccess] | 165 | memset(this, 0, offsetof(VPS, hrd_layer_set_idx)); | | ^ | In file included from ../../git/codecparsers/h265Parser.cpp:21: | ../../git/codecparsers/h265Parser.h:256:12: note: 'struct YamiParser::H265::VPS' declared here | 256 | struct VPS { | | ^~~ | ../../git/codecparsers/h265Parser.cpp: In constructor 'YamiParser::H265::SPS::SPS()': | ../../git/codecparsers/h265Parser.cpp:174:39: error: 'void* memset(void*, int, size_t)' clearing an object of type 'struct YamiParser::H265::SPS' with no trivial copy-assignment; use assignment or value-initialization instead [-Werror=class-memaccess] | 174 | memset(this, 0, offsetof(SPS, vps)); | | ^ | In file included from ../../git/codecparsers/h265Parser.cpp:21: | ../../git/codecparsers/h265Parser.h:290:12: note: 'struct YamiParser::H265::SPS' declared here | 290 | struct SPS { | | ^~~ | ../../git/codecparsers/h265Parser.cpp: In constructor 'YamiParser::H265::PPS::PPS()': | ../../git/codecparsers/h265Parser.cpp:179:39: error: 'void* memset(void*, int, size_t)' clearing an object of type 'struct YamiParser::H265::PPS' with no trivial copy-assignment; use assignment or value-initialization instead [-Werror=class-memaccess] | 179 | memset(this, 0, offsetof(PPS, sps)); | | ^ | In file included from ../../git/codecparsers/h265Parser.cpp:21: | ../../git/codecparsers/h265Parser.h:362:12: note: 'struct YamiParser::H265::PPS' declared here | 362 | struct PPS { | | ^~~ | ../../git/codecparsers/h265Parser.cpp: In constructor 'YamiParser::H265::SliceHeader::SliceHeader()': | ../../git/codecparsers/h265Parser.cpp:184:47: error: 'void* memset(void*, int, size_t)' clearing an object of type 'struct YamiParser::H265::SliceHeader' with no trivial copy-assignment; use assignment or value-initialization instead [-Werror=class-memaccess] | 184 | memset(this, 0, offsetof(SliceHeader, pps)); | | ^ | In file included from ../../git/codecparsers/h265Parser.cpp:21: | ../../git/codecparsers/h265Parser.h:499:12: note: 'struct YamiParser::H265::SliceHeader' declared here | 499 | struct SliceHeader { | | ^~~~~~~~~~~ | ../../git/codecparsers/mpeg2_parser.cpp: In constructor 'YamiParser::MPEG2::SeqHeader::SeqHeader()': | ../../git/codecparsers/mpeg2_parser.cpp:163:59: error: 'void* memset(void*, int, size_t)' clearing an object of non-trivial type 'struct YamiParser::MPEG2::SeqHeader'; use assignment or value-initialization instead [-Werror=class-memaccess] | 163 | SeqHeader::SeqHeader() { memset(this, 0, sizeof(*this)); } | | ^ | In file included from ../../git/codecparsers/mpeg2_parser.cpp:34: | ../../git/codecparsers/mpeg2_parser.h:153:12: note: 'struct YamiParser::MPEG2::SeqHeader' declared here | 153 | struct SeqHeader { | | ^~~~~~~~~ | cc1plus: all warnings being treated as errors By typecasting structure pointer to void pointer, GCC9 does normal memset operation where offsetof() give correct number of bytes to set. Signed-off-by: Naveen Saini <[email protected]>

xuguangxin · 2019-06-12T03:51:32Z

@wangzj0601 , could you help run regression test for this too.
thanks

xuguangxin · 2019-06-24T07:47:41Z

@wangzj0601 , any feedback on this?
thanks

xuguangxin · 2019-07-25T01:56:59Z

thanks @saininav for this.

saininav force-pushed the apache branch from ba98ec2 to 6e8ac3c Compare June 4, 2019 07:51

xuguangxin reviewed Jun 10, 2019

View reviewed changes

saininav force-pushed the apache branch from 6e8ac3c to 5912d2c Compare June 11, 2019 03:17

xuguangxin approved these changes Jun 11, 2019

View reviewed changes

xuguangxin mentioned this pull request Jun 11, 2019

Compilation fails with gcc version 9.1.1 20190503 on Fedora 30 #875

Open

saininav force-pushed the apache branch from 5912d2c to 34b0a42 Compare June 11, 2019 15:30

xuguangxin merged commit f742635 into intel:apache Jul 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

h26xparser: Fix build error with GCC9 #876

h26xparser: Fix build error with GCC9 #876

saininav commented Jun 3, 2019

xuguangxin commented Jun 3, 2019

xuguangxin Jun 10, 2019

saininav Jun 10, 2019

xuguangxin Jun 10, 2019

saininav Jun 10, 2019 •

edited

Loading

saininav Jun 10, 2019

xuguangxin Jun 10, 2019

saininav Jun 11, 2019

xuguangxin commented Jun 10, 2019

xuguangxin left a comment

xuguangxin commented Jun 11, 2019

xuguangxin commented Jun 12, 2019

xuguangxin commented Jun 24, 2019

xuguangxin commented Jul 25, 2019

h26xparser: Fix build error with GCC9 #876

h26xparser: Fix build error with GCC9 #876

Conversation

saininav commented Jun 3, 2019

xuguangxin commented Jun 3, 2019

xuguangxin Jun 10, 2019

Choose a reason for hiding this comment

saininav Jun 10, 2019

Choose a reason for hiding this comment

xuguangxin Jun 10, 2019

Choose a reason for hiding this comment

saininav Jun 10, 2019 • edited Loading

Choose a reason for hiding this comment

saininav Jun 10, 2019

Choose a reason for hiding this comment

xuguangxin Jun 10, 2019

Choose a reason for hiding this comment

saininav Jun 11, 2019

Choose a reason for hiding this comment

xuguangxin commented Jun 10, 2019

xuguangxin left a comment

Choose a reason for hiding this comment

xuguangxin commented Jun 11, 2019

xuguangxin commented Jun 12, 2019

xuguangxin commented Jun 24, 2019

xuguangxin commented Jul 25, 2019

saininav Jun 10, 2019 •

edited

Loading