Fix include directories and generated header files in Android.bp #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build artifact of libva has va_drm.h in va/ directory. This is done by va/drm/Makefile.am in libva. Therefore, code typically includes va/va_drm.h. This CL modifies Android.bp so `libva_gen_headers` copy va_drm.h in va/ directory and `libva` sets include path to the generated headers.
|
This is upstream to https://android-review.git.corp.google.com/c/platform/external/libva/+/3323640 |
|
@XinfengZhang Could you change this patch? |
XinfengZhang
approved these changes
Nov 27, 2024
|
LGTM, from this patch, android need to use drm interface directly, suppose we will remove va_android.cpp in future? |
|
I agree. I am happy to remove |
|
Could you merge this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build artifact of libva has va_drm.h in va/ directory. This is done by va/drm/Makefile.am in libva. Therefore, code typically includes va/va_drm.h. This CL modifies Android.bp so
libva_gen_headerscopy va_drm.h in va/ directory andlibvasets include path to the generated headers.