refine encode segment id map buffer #756
Conversation
va/va_enc_av1.h
Outdated
| /** | ||
| * \brief AV1 Block Segmentation ID Buffer | ||
| * | ||
| * The application provides a buffer of VAEncMacroblockMapBufferType containing |
There was a problem hiding this comment.
Do we need to set size and num_elements in vaCreateBuffer to width and height as well as in vp9, respectively?
There was a problem hiding this comment.
it is a kind of backward combability issue, I want to unify them to a linear buffer. so, the question is: is there other user beside intel media driver , is there any application is using the older interface?
There was a problem hiding this comment.
Would it be a better solution if we keep the original behavior when calling vaCreateBuffer with VAEncMacroblockMapBufferType, and we define a new BufferType (e.g. named VAEncUnifiedSegmentationMapBufferType).
There are some benefits but libva will a little bit complicated.
We can keep all the backward compability and suggest/guide app-developers to switch to the new/unified interface.
There was a problem hiding this comment.
so, we support both for VP9?
There was a problem hiding this comment.
Yes, I would prefer that.
It would benefit the application maintenance effort.
However, it will make libva more complicated......
| @@ -670,7 +672,6 @@ typedef struct _VAEncPictureParameterBufferAV1 { | |||
| * 0: 16x16 block size, default value; | |||
| * 1: 32x32 block size; | |||
| * 2: 64x64 block size; | |||
| * 3: 8x8 block size. | |||
There was a problem hiding this comment.
Why is this removed?
For the consisency to vp9, should this be VA_SEGID_BLOCKXXX?
|
@rosetta-jpn , updated. how about this version? |
XinfengZhang
force-pushed
the
seg
branch
2 times, most recently
from
e7f68e0 to
8265d88
Compare
| /** \brief each segmentID represent a 64x64 block */ | ||
| #define VA_SEGID_BLOCK_64X64 2 | ||
| /** \brief each segmentID represent a 8x8 block */ | ||
| #define VA_SEGID_BLOCK_8X8 3 |
There was a problem hiding this comment.
nit: Shall we add VA_SEGID_BLOCK_4x4? AV1 is 4x4 seg map.
|
Sorry for so delayed review. |
Signed-off-by: Carl Zhang <[email protected]>
Signed-off-by: Yao, Leyu <[email protected]> Signed-off-by: Zhang,Carl <[email protected]>
previous description limited the segment id block 8x8 it is not accurate and should support different block size which could be set by picture parameter. attention: this change will impact backward compatiblility, considering no one is using it. we could ignore this side effect Signed-off-by: Carl Zhang <[email protected]>
attention: these change will break backward compatibility, the pre-assumption is no one is using them besides intel media driver and intel oneVPL runtime, if there are other customer, it should be risky
so, please help to check whether there are somebody are using segment id map buffer for avc or vp9 encoding.