add surface hint for recon/reference/raw #344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulinjie
reviewed
Oct 15, 2019
XinfengZhang
force-pushed
the
hint
branch
2 times, most recently
from
73bfa02 to
3de8b05
Compare
fulinjie
reviewed
Oct 17, 2019
this surface hint is used to require usage hint for some codec , to optimize the memory footprint reconstruct surface is use another format for example, if input surface is AYUV for encode, it 444 format, backend driver maybe just use YUV to be reference, A is ignored to safe memory. in this scenario, application should not confuse the raw input surface and reconstruct/reference surface. Signed-off-by: Carl Zhang <[email protected]>
|
Information is enough. |
|
Here is some comments from the community: The basic question is why not handling it transparently (and not to introduce extra attribute). |
|
to make it transparent, it will bring a lot of effort, 1. need to record the real format information inside driver. 2. do not create real surface until it is was used, it is difficult to implement it, we we call vaCreateSurfaces, we even don't know the context, config... |
|
close it for intel/media-driver#915 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Carl Zhang [email protected]