Skip to content

Commit

Permalink
va: Add VAConfigAttribEncMaxTileRows and VAConfigAttribEncMaxTileCols
Browse files Browse the repository at this point in the history
Currently there is no way of exposing the driver tile_rows and tile_cols limitations
for encoding with tiles. For codecs like AV1 there is a cap specifying the max number
of tiles, but without differentiating cols/rows.

Different hardware may have restrictions which may need to be taken into account.
More specifically, D3D12 encode exposes the maximum rows/cols and adding
VAConfigAttribEncMaxTileRows/Cols allows for mapping that information to the VAOn12 driver.

Signed-off-by: Sil Vilerino <[email protected]>
  • Loading branch information
sivileri committed Sep 28, 2023
1 parent 53e459d commit e5758c4
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
14 changes: 14 additions & 0 deletions va/va.h
Original file line number Diff line number Diff line change
Expand Up @@ -1036,6 +1036,20 @@ typedef enum {
* The value returned uses the VAConfigAttribValEncPerBlockControl type.
*/
VAConfigAttribEncPerBlockControl = 55,
/**
* \brief Maximum number of tile rows. Read-only.
*
* This attribute determines the maximum number of tile
* rows supported for encoding with tile support.
*/
VAConfigAttribEncMaxTileRows = 56,
/**
* \brief Maximum number of tile cols. Read-only.
*
* This attribute determines the maximum number of tile
* columns supported for encoding with tile support.
*/
VAConfigAttribEncMaxTileCols = 57,
/**@}*/
VAConfigAttribTypeMax
} VAConfigAttribType;
Expand Down
2 changes: 2 additions & 0 deletions va/va_str.c
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@ const char *vaConfigAttribTypeStr(VAConfigAttribType configAttribType)
TOSTR(VAConfigAttribEncAV1Ext1);
TOSTR(VAConfigAttribEncAV1Ext2);
TOSTR(VAConfigAttribEncPerBlockControl);
TOSTR(VAConfigAttribEncMaxTileRows);
TOSTR(VAConfigAttribEncMaxTileCols);
case VAConfigAttribTypeMax:
break;
}
Expand Down

0 comments on commit e5758c4

Please sign in to comment.