-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Barrier and Timing to the Python Interface #31
base: development
Are you sure you want to change the base?
Conversation
Hi @cangumeli, it seems to me that "MPI_Wtime()" returns the number of seconds elapsed from a specific point in the past. The value of "MPI_Wtime()" cannot therefore be directly compared between processes. |
The barrier-related contribution works fine. The min/max time approach may not be the best for timing the code in Python. One simple alternative is: Another approach requires that, at the point of the initialization of the MPI environment, we store the "MPI_Wtime()" separately for every process. When min/ax time is called, we return the time difference with the fixed "initialization time" of the process. However, one must be able to assume that the initialization of every process happens at the same time and this may not be the case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my previous two comments.
There is an issue with MinTime() and MaxTime().
I will be looking into it to find a better way of timing. Thanks for the response. |
When I added min/max time, I actually thought barriers in Python don't work. However, with this contribution, they should work. So I am not sure max and min time are really necessary anymore, maybe we can just do something like this in Python:
|
That is what I was thinking too: Providing the barrier command should suffice for most applications. |
Yes that is my idea. I will make the change and comment here when I have time :). |
No description provided.