[NEX-15262] Returns failure reason that matches the format required by MM #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MM This PR refines the failure_reason in the granular log to match the mapping required by MM. It detects keywords in the error message and maps the error message to the corresponding Enum of the failure_reason. This PR also fixes an issue where the granular log handler didn't record the command's error when run_commands failed to run the cmd_list. Signed-off-by: yengliong <[email protected]>
|
@gblewis1 Could you please review the PR? |
gblewis1
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL DESCRIPTION
This PR refines the failure_reason in the granular log to match the mapping required by MM. It detects keywords in the error message and maps the error message to the corresponding Enum of the failure_reason.
This PR also fixes an issue where the granular log handler didn't record the command's error when run_commands failed to run the cmd_list.
Impact Analysis
CODE MAINTAINABILITY
go fmtorformat-python.shas applicableCode must act as a teacher for future developers