Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEXMANAGE-853] Remove ORAS and update method #569

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[NEXMANAGE-853] Remove ORAS and update method #569

merged 2 commits into from
Oct 15, 2024

Conversation

yengliong93
Copy link
Contributor

@yengliong93 yengliong93 commented Oct 11, 2024 •
edited
Loading

PULL DESCRIPTION

The image can be downloaded from the release server now. It still
requires the JWT token. This PR removes ORAS related module and update the method for downloading the image using requests module.

Impact Analysis

Info Please fill out this column
Root Cause Specifically for bugs, empty in case of no variants
Jira ticket NEXMANAGE-853

CODE MAINTAINABILITY

  • Added required new tests relevant to the changes
  • Updated Documentation as relevant to the changes
  • PR change contains code related to security
  • PR introduces changes that break compatibility with other modules/services (If YES, please provide description)
  • Run go fmt or format-python.sh as applicable
  • Update Changelog
  • Integration tests are passing
  • If Cloudadapter changes, check Azure connectivity manually

Code must act as a teacher for future developers

@yengliong93 yengliong93 changed the title WIP: Remove ORAS and update method WIP: [NEXMANAGE-853] Remove ORAS and update method Oct 14, 2024
@yengliong93 yengliong93 changed the title WIP: [NEXMANAGE-853] Remove ORAS and update method [NEXMANAGE-853] Remove ORAS and update method Oct 14, 2024
@yengliong93
[NEXMANAGE-853] Remove ORAS and update method
401264e 
The image can be downloaded from the release server now. It still
requires the JWT token. This PR removes ORAS related module and update the method for downloading the image using requests module.

Signed-off-by: yengliong <[email protected]>
@yengliong93
Copy link
Contributor Author

@gblewis1 Please have a review, thanks.

@yengliong93
Copy link
Contributor Author

@gblewis1 Please have a review again, thanks.

@gblewis1 gblewis1 merged commit 953edff into develop Oct 15, 2024
15 checks passed
@gblewis1 gblewis1 deleted the remove-oras branch October 15, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gblewis1 gblewis1 gblewis1 approved these changes

@nmgaston nmgaston Awaiting requested review from nmgaston nmgaston is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yengliong93 @gblewis1