Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Update to NodeUpdate #560

Merged
merged 9 commits into from
Oct 4, 2024
Merged

Rename Update to NodeUpdate #560

merged 9 commits into from
Oct 4, 2024

Conversation

nmgaston
Copy link
Contributor

@nmgaston nmgaston commented Oct 2, 2024 •
edited
Loading

PULL DESCRIPTION

Rename 'update' channel between cloudadapter and dispatcher to 'nodeupdate'. Also any associated constants and methods.

Impact Analysis

Info Please fill out this column
Jira ticket NEXMANAGE-789

CODE MAINTAINABILITY

  • Added required new tests relevant to the changes
  • Updated Documentation as relevant to the changes
  • PR change contains code related to security
  • PR introduces changes that break compatibility with other modules/services (If YES, please provide description)
  • Run go fmt or format-python.sh as applicable
  • Update Changelog
  • Integration tests are passing
  • If Cloudadapter changes, check Azure connectivity manually

Code must act as a teacher for future developers

@nmgaston nmgaston marked this pull request as ready for review October 4, 2024 17:30
@nmgaston nmgaston requested a review from gblewis1 as a code owner October 4, 2024 17:30
@nmgaston nmgaston merged commit eab9ae6 into develop Oct 4, 2024
7 checks passed
@nmgaston nmgaston deleted the changeUpdateToNodeUpdate branch October 4, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gblewis1 gblewis1 gblewis1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmgaston @gblewis1