[NEXMANAGE-430] Fixed Ping completed but cloudadapter shows error (#531)

message Since the INBS ping request doesn't reach dispatcher, the cloudadapter will skip the checks for dispatcher state if it's a INBS ping request. Signed-off-by: yengliong <[email protected]>
intel · Jul 31, 2024 · 98808aa · 98808aa
1 parent 7d9c222
commit 98808aa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/inbm/Changelog.md b/inbm/Changelog.md
@@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
  - Fixed some Yocto issues found after migrating to scarthgap
  - (NEXARL-195) Fixed device tree detection check on systems that implement only part of device tree
  - (NEXARL-279) Fixed system would not be able to access secret volume after fwupd on Arrow Lake platform
+ - (NEXMANAGE-430) Fixed Ping completed but cloudadapter shows error message
 
 ### Security
  - Bump requests from 2.31.0 to 2.32.2 in multiple agents resolving detected 3rd party CVE: CVE-2024-35195

diff --git a/inbm/cloudadapter-agent/cloudadapter/cloud/client/inbs_cloud_client.py b/inbm/cloudadapter-agent/cloudadapter/cloud/client/inbs_cloud_client.py
@@ -162,8 +162,9 @@ def _handle_inbm_command_request(
 
                 request_id = item.request_id
                 logger.debug(f"Processing gRPC request: request_id {request_id}")
+                command_type = item.command.WhichOneof("inbm_command")
 
-                if self.get_dispatcher_state() == DEAD:
+                if self.get_dispatcher_state() == DEAD and command_type != "ping":
                     logger.error(
                         f"Dispatcher not in running state. Unable to process request - {request_id}"
                     )
@@ -175,7 +176,7 @@ def _handle_inbm_command_request(
                     )
                     continue
 
-                command_type = item.command.WhichOneof("inbm_command")
+
                 if command_type:
                     if command_type == "update_scheduled_operations":
                         # Convert operations to Dispatcher's ScheduleRequest

diff --git a/inbm/cloudadapter-agent/tests/unit/cloud/client/test_inbs_cloud_client.py b/inbm/cloudadapter-agent/tests/unit/cloud/client/test_inbs_cloud_client.py
@@ -156,7 +156,7 @@ def test_handle_command_when_dispatcher_is_not_up(self, inbs_client: InbsCloudCl
 
         # Construct command using parameters
         command = inbs_sb_pb2.HandleINBMCommandRequest(
-            request_id="123", command=inbs_sb_pb2.INBMCommand(ping=inbs_sb_pb2.Ping())
+            request_id="123", command=inbs_sb_pb2.INBMCommand(update_scheduled_operations=inbs_sb_pb2.UpdateScheduledOperations())
         )
         request_queue.put(command)
         request_queue.put(None)  # Sentinel to end the generator