Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing install command to Source/GmmLib/CMakeLists.txt #10

Closed
wants to merge 1 commit into from
Closed

Add missing install command to Source/GmmLib/CMakeLists.txt #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Source/GmmLib/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,3 +545,4 @@ if(ARCH EQUAL 32)
endif()

add_subdirectory(ULT)
install(TARGETS gmm_umd ARCHIVE DESTINATION lib)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately that's not enough. It is important to install header files as well for other projects like media-driver to be able to link against gmmlib.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvrogozh are all headers in "Source/inc"? Should the same dir structure (common, umKmInc) be installed to the system include dir?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I afraid they are scattered:(. This is highlighted here: #5. The problem is that I don't even know which include files are needed and which are not (sorry I am not in the gmmlib team). Probably the best way to approach this would be to take some project which depends on gmmlib, for example media-driver, wipe out current detection of gmmlib and substitute it with the proper detection by gmmlib.pc, after that start add include files one by one depending on compilation errors.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are working on a transition from gmmlib static lib to dynamic library and this issue will be addressed as part of the transition process. We are considering all open packaging requirements.