This repository has been archived by the owner on Jan 7, 2023. It is now read-only.
Transports #92
Open
Transports #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
This makes decoding bytes and strings consistent with all other CBOR decode functions return DPS_ERR_EOD and do not modify the rxPos when there is not enough data available. Signed-off-by: Todd Malsbary <[email protected]>
In general, uv_pipe_getpeername() will return an empty name. Looking up remotes requires a unique name to work properly. Signed-off-by: Todd Malsbary <[email protected]>
Signed-off-by: Todd Malsbary <[email protected]>
GregBurns
reviewed
Apr 16, 2019
examples/reg_subs.c
Outdated
| @@ -85,7 +85,7 @@ static void OnPubMatch(DPS_Subscription* sub, const DPS_Publication* pub, uint8_ | |||
| } | |||
| } | |||
|
|
|||
| static DPS_Status RegisterAndJoin(DPS_Node* node, char** linkText, int numLink, | |||
| static DPS_Status RegisterAndJoin(DPS_Node* node, char* network, char** linkText, int numLink, | |||
There was a problem hiding this comment.
Should this be "const char* network"?
GregBurns
reviewed
Apr 16, 2019
go/dps.go
Outdated
| @@ -135,8 +135,8 @@ import ( | |||
| goOnResolveAddressComplete(node, (DPS_NodeAddress*)addr, (uintptr_t)data); | |||
| } | |||
|
|
|||
| static DPS_Status resolveAddress(DPS_Node* node, char* host, char* service, uintptr_t data) { | |||
| return DPS_ResolveAddress(node, host, service, onResolveAddressComplete, (void*)data); | |||
| static DPS_Status resolveAddress(DPS_Node* node, char* network, char* host, char* service, uintptr_t data) { | |||
Signed-off-by: Todd Malsbary <[email protected]>
GregBurns
approved these changes
May 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.