fix: GNR and XML Schema definition #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joko-sastriawan
commented
Jul 18, 2024
joko-sastriawan
commented
- GNR OOBMSM CORE, RMID and RMID-EE spec clarification
- adjust XML schema to address schema validation challenges
- GNR OOBMSM CORE, RMID and RMID-EE spec clarification - adjust XML schema to address schema validation challenges
mduchals
approved these changes
Jul 18, 2024
| @@ -493,63 +493,63 @@ | |||
| <TELC:lsb>15</TELC:lsb> | |||
| <TELC:msb>17</TELC:msb> | |||
| </TELC:sample> | |||
| <TELC:sample name="Atom Core0" datatypeIDREF="tgeneric_sample" sampleID="Atom Core0"> | |||
There was a problem hiding this comment.
Last update date has not been updated for MTL. I assume that's intentional as the changes are minor?
There was a problem hiding this comment.
yes, it is minor changes
mlawnicz
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.