fix: MTL pkgc_wake_cause and pkgc_block_cause (#51)

- remove pkgc_wake_cause and pkgc_block_cause on unused aggregator - define diec_wake_cause and diec_block_cause for die related metric
intel · Sep 9, 2024 · c172263 · c172263
1 parent 2d920a6
commit c172263
Show file tree

Hide file tree

Showing 10 changed files with 169 additions and 83 deletions.
diff --git a/xml/MTL/0/mtl_aggregator_interface.xml b/xml/MTL/0/mtl_aggregator_interface.xml
@@ -17,20 +17,6 @@
 			</TransFormParameters>
 			<transform>$parameter_0 / 38.4 * 1e6 </transform>
 		</TransFormation>
-		<TransFormation name="pkgc_wake_cause" transformID="pkgc_wake_cause">
-			<output_dataclass>float</output_dataclass>
-			<TransFormParameters>
-				<parameterName>parameter_0</parameterName>
-			</TransFormParameters>
-			<transform>$parameter_0 / PACKAGE_CSTATE_WAKE_REFCNT * 100 </transform>
-		</TransFormation>
-		<TransFormation name="pkgc_block_cause" transformID="pkgc_block_cause">
-			<output_dataclass>float</output_dataclass>
-			<TransFormParameters>
-				<parameterName>parameter_0</parameterName>
-			</TransFormParameters>
-			<transform>$parameter_0 / PACKAGE_CSTATE_BLOCK_REFCNT * 100 </transform>
-		</TransFormation>
 		<TransFormation name="wp_volts" transformID="wp_volts">
 			<output_dataclass>float</output_dataclass>
 			<TransFormParameters>
@@ -248,7 +234,7 @@
 	<TELI:uniqueid>0x130670B2</TELI:uniqueid>
 	<TELI:NDA>Public</TELI:NDA>
 	<TELI:samplePeriod>10</TELI:samplePeriod>
-	<TELI:revisionDate>2023-11-28</TELI:revisionDate>
+	<TELI:revisionDate>2024-09-06</TELI:revisionDate>
 	<TELI:AggregatorSamples>
 		<TELI:T_AggregatorSample sampleName="VPU_MEMORY_BW" sampleGroup="VPU_MEMORY_BW" datatypeIDREF="tbw_KB" sampleID="0">
 			<TELI:description>Average DDR BW over a time interval (VPU counts in KB)</TELI:description>

diff --git a/xml/MTL/0/mtl_common.xml b/xml/MTL/0/mtl_common.xml
@@ -25,6 +25,20 @@
 			</TELC:units>
 		<TELC:format>ANY</TELC:format>
 	</TELC:dataType>
+	<TELC:dataType name="tdiec_wake_cause" datatypeID="tdiec_wake_cause">
+		<TELC:dataclass>counter</TELC:dataclass>
+			<TELC:units name="percent">
+				<TELC:symbol>%</TELC:symbol>
+			</TELC:units>
+		<TELC:format>ANY</TELC:format>
+	</TELC:dataType>
+	<TELC:dataType name="tdiec_block_cause" datatypeID="tdiec_block_cause">
+		<TELC:dataclass>counter</TELC:dataclass>
+			<TELC:units name="percent">
+				<TELC:symbol>%</TELC:symbol>
+			</TELC:units>
+		<TELC:format>ANY</TELC:format>
+	</TELC:dataType>
 	<TELC:dataType name="twp_volts" datatypeID="twp_volts">
 		<TELC:dataclass>status</TELC:dataclass>
 			<TELC:units name="volts">

diff --git a/xml/MTL/1/mtl_aggregator_interface.xml b/xml/MTL/1/mtl_aggregator_interface.xml
@@ -250,7 +250,7 @@
 	<TELI:uniqueid>0x130671B2</TELI:uniqueid>
 	<TELI:NDA>Public</TELI:NDA>
 	<TELI:samplePeriod>10</TELI:samplePeriod>
-	<TELI:revisionDate>2023-11-28</TELI:revisionDate>
+	<TELI:revisionDate>2024-09-06</TELI:revisionDate>
 	<TELI:AggregatorSamples>
 		<TELI:T_AggregatorSample sampleName="EXTENDED_TELE_ID_SPECIFIC_HEADER" sampleGroup="EXTENDED_TELE_ID_SPECIFIC_HEADER" datatypeIDREF="tgeneric_counter" sampleID="0">
 			<TELI:description>NOT a counter. Indicates the format of extended fixed telemetry regionBits 7:0 - NUM_RAW_BLOCK_REASONS - Number of counters in &quot;raw block reasons&quot; sub-categoryBits 15:8 - NUM_RAW_WAKE_REASONS_PC6_PC10Bits 23:16 - NUM_DEMOTION_CAUSES_PC6_PC10Bits 31:24 - NUM_BLOCK_CAUSES_PC6_PC10</TELI:description>

diff --git a/xml/MTL/1/mtl_common.xml b/xml/MTL/1/mtl_common.xml
@@ -25,6 +25,20 @@
 			</TELC:units>
 		<TELC:format>ANY</TELC:format>
 	</TELC:dataType>
+	<TELC:dataType name="tdiec_wake_cause" datatypeID="tdiec_wake_cause">
+		<TELC:dataclass>counter</TELC:dataclass>
+			<TELC:units name="percent">
+				<TELC:symbol>%</TELC:symbol>
+			</TELC:units>
+		<TELC:format>ANY</TELC:format>
+	</TELC:dataType>
+	<TELC:dataType name="tdiec_block_cause" datatypeID="tdiec_block_cause">
+		<TELC:dataclass>counter</TELC:dataclass>
+			<TELC:units name="percent">
+				<TELC:symbol>%</TELC:symbol>
+			</TELC:units>
+		<TELC:format>ANY</TELC:format>
+	</TELC:dataType>
 	<TELC:dataType name="twp_volts" datatypeID="twp_volts">
 		<TELC:dataclass>status</TELC:dataclass>
 			<TELC:units name="volts">

diff --git a/xml/MTL/2/mtl_aggregator_interface.xml b/xml/MTL/2/mtl_aggregator_interface.xml
@@ -17,20 +17,6 @@
 			</TransFormParameters>
 			<transform>$parameter_0 / 38.4 * 1e6 </transform>
 		</TransFormation>
-		<TransFormation name="pkgc_wake_cause" transformID="pkgc_wake_cause">
-			<output_dataclass>float</output_dataclass>
-			<TransFormParameters>
-				<parameterName>parameter_0</parameterName>
-			</TransFormParameters>
-			<transform>$parameter_0 / PACKAGE_CSTATE_WAKE_REFCNT * 100 </transform>
-		</TransFormation>
-		<TransFormation name="pkgc_block_cause" transformID="pkgc_block_cause">
-			<output_dataclass>float</output_dataclass>
-			<TransFormParameters>
-				<parameterName>parameter_0</parameterName>
-			</TransFormParameters>
-			<transform>$parameter_0 / PACKAGE_CSTATE_BLOCK_REFCNT * 100 </transform>
-		</TransFormation>
 		<TransFormation name="wp_volts" transformID="wp_volts">
 			<output_dataclass>float</output_dataclass>
 			<TransFormParameters>
@@ -248,7 +234,7 @@
 	<TELI:uniqueid>0x1A067002</TELI:uniqueid>
 	<TELI:NDA>Public</TELI:NDA>
 	<TELI:samplePeriod>10</TELI:samplePeriod>
-	<TELI:revisionDate>2023-11-28</TELI:revisionDate>
+	<TELI:revisionDate>2024-09-06</TELI:revisionDate>
 	<TELI:AggregatorSamples>
 		<TELI:T_AggregatorSample sampleName="LOCAL_VERSION" sampleGroup="GLOBAL_ID" datatypeIDREF="tgeneric_sample" sampleID="0">
 			<TELI:description>revision of the xml</TELI:description>

diff --git a/xml/MTL/2/mtl_common.xml b/xml/MTL/2/mtl_common.xml
@@ -25,6 +25,20 @@
 			</TELC:units>
 		<TELC:format>ANY</TELC:format>
 	</TELC:dataType>
+	<TELC:dataType name="tdiec_wake_cause" datatypeID="tdiec_wake_cause">
+		<TELC:dataclass>counter</TELC:dataclass>
+			<TELC:units name="percent">
+				<TELC:symbol>%</TELC:symbol>
+			</TELC:units>
+		<TELC:format>ANY</TELC:format>
+	</TELC:dataType>
+	<TELC:dataType name="tdiec_block_cause" datatypeID="tdiec_block_cause">
+		<TELC:dataclass>counter</TELC:dataclass>
+			<TELC:units name="percent">
+				<TELC:symbol>%</TELC:symbol>
+			</TELC:units>
+		<TELC:format>ANY</TELC:format>
+	</TELC:dataType>
 	<TELC:dataType name="twp_volts" datatypeID="twp_volts">
 		<TELC:dataclass>status</TELC:dataclass>
 			<TELC:units name="volts">

diff --git a/xml/MTL/3/mtl_aggregator.xml b/xml/MTL/3/mtl_aggregator.xml
@@ -49,15 +49,15 @@
 	<TELEM:SampleGroup name="Container_2" sampleID="2" sampleGroupID="Container_2">
 		<TELC:description>Groupname 0x16010</TELC:description>
 		<TELC:length>64</TELC:length>
-		<TELC:sample name="DIE_CSTATE_BLOCK_CAUSE_CORE" datatypeIDREF="tpkgc_block_cause" sampleID="DIE_CSTATE_BLOCK_CAUSE_CORE">
+		<TELC:sample name="DIE_CSTATE_BLOCK_CAUSE_CORE" datatypeIDREF="tdiec_block_cause" sampleID="DIE_CSTATE_BLOCK_CAUSE_CORE">
 			<TELC:description>Counts the number of 1ms intervals during which DieC entry was blocked at least once by CORE</TELC:description>
 			<TELC:sampleSubGroup>DIE_CSTATE_BLOCK_CAUSE_CORE</TELC:sampleSubGroup>
 			<TELC:sampleType>Counter</TELC:sampleType>
 			<TELC:size>32</TELC:size>
 			<TELC:lsb>0</TELC:lsb>
 			<TELC:msb>31</TELC:msb>
 		</TELC:sample>
-		<TELC:sample name="DIE_CSTATE_BLOCK_CAUSE_RING" datatypeIDREF="tpkgc_block_cause" sampleID="DIE_CSTATE_BLOCK_CAUSE_RING">
+		<TELC:sample name="DIE_CSTATE_BLOCK_CAUSE_RING" datatypeIDREF="tdiec_block_cause" sampleID="DIE_CSTATE_BLOCK_CAUSE_RING">
 			<TELC:description>Counts the number of 1ms intervals during which DieC entry was blocked at least once by RING</TELC:description>
 			<TELC:sampleSubGroup>DIE_CSTATE_BLOCK_CAUSE_RING</TELC:sampleSubGroup>
 			<TELC:sampleType>Counter</TELC:sampleType>
@@ -69,15 +69,15 @@
 	<TELEM:SampleGroup name="Container_3" sampleID="3" sampleGroupID="Container_3">
 		<TELC:description>Groupname 0x16018</TELC:description>
 		<TELC:length>64</TELC:length>
-		<TELC:sample name="DIE_CSTATE_BLOCK_CAUSE_GPSB" datatypeIDREF="tpkgc_block_cause" sampleID="DIE_CSTATE_BLOCK_CAUSE_GPSB">
+		<TELC:sample name="DIE_CSTATE_BLOCK_CAUSE_GPSB" datatypeIDREF="tdiec_block_cause" sampleID="DIE_CSTATE_BLOCK_CAUSE_GPSB">
 			<TELC:description>Counts the number of 1ms intervals during which DieC entry was blocked at least once by GPSB</TELC:description>
 			<TELC:sampleSubGroup>DIE_CSTATE_BLOCK_CAUSE_GPSB</TELC:sampleSubGroup>
 			<TELC:sampleType>Counter</TELC:sampleType>
 			<TELC:size>32</TELC:size>
 			<TELC:lsb>0</TELC:lsb>
 			<TELC:msb>31</TELC:msb>
 		</TELC:sample>
-		<TELC:sample name="DIE_CSTATE_BLOCK_CAUSE_PUNIT" datatypeIDREF="tpkgc_block_cause" sampleID="DIE_CSTATE_BLOCK_CAUSE_PUNIT">
+		<TELC:sample name="DIE_CSTATE_BLOCK_CAUSE_PUNIT" datatypeIDREF="tdiec_block_cause" sampleID="DIE_CSTATE_BLOCK_CAUSE_PUNIT">
 			<TELC:description>Counts the number of 1ms intervals during which DieC entry was blocked at least once by PUNIT</TELC:description>
 			<TELC:sampleSubGroup>DIE_CSTATE_BLOCK_CAUSE_PUNIT</TELC:sampleSubGroup>
 			<TELC:sampleType>Counter</TELC:sampleType>
@@ -89,15 +89,15 @@
 	<TELEM:SampleGroup name="Container_4" sampleID="4" sampleGroupID="Container_4">
 		<TELC:description>Groupname 0x16020</TELC:description>
 		<TELC:length>64</TELC:length>
-		<TELC:sample name="DIE_CSTATE_BLOCK_CAUSE_ARAT" datatypeIDREF="tpkgc_block_cause" sampleID="DIE_CSTATE_BLOCK_CAUSE_ARAT">
+		<TELC:sample name="DIE_CSTATE_BLOCK_CAUSE_ARAT" datatypeIDREF="tdiec_block_cause" sampleID="DIE_CSTATE_BLOCK_CAUSE_ARAT">
 			<TELC:description>Counts the number of 1ms intervals during which DieC entry was blocked at least once by ARAT timers</TELC:description>
 			<TELC:sampleSubGroup>DIE_CSTATE_BLOCK_CAUSE_ARAT</TELC:sampleSubGroup>
 			<TELC:sampleType>Counter</TELC:sampleType>
 			<TELC:size>32</TELC:size>
 			<TELC:lsb>0</TELC:lsb>
 			<TELC:msb>31</TELC:msb>
 		</TELC:sample>
-		<TELC:sample name="DIE_CSTATE_WAKE_REASON_PUNIT" datatypeIDREF="tpkgc_wake_cause" sampleID="DIE_CSTATE_WAKE_REASON_PUNIT">
+		<TELC:sample name="DIE_CSTATE_WAKE_REASON_PUNIT" datatypeIDREF="tdiec_wake_cause" sampleID="DIE_CSTATE_WAKE_REASON_PUNIT">
 			<TELC:description>Die C-state wake due to Punit</TELC:description>
 			<TELC:sampleSubGroup>DIE_CSTATE_WAKE_REASON_PUNIT</TELC:sampleSubGroup>
 			<TELC:sampleType>Counter</TELC:sampleType>
@@ -109,15 +109,15 @@
 	<TELEM:SampleGroup name="Container_5" sampleID="5" sampleGroupID="Container_5">
 		<TELC:description>Groupname 0x16028</TELC:description>
 		<TELC:length>64</TELC:length>
-		<TELC:sample name="DIE_CSTATE_WAKE_REASON_RING" datatypeIDREF="tpkgc_wake_cause" sampleID="DIE_CSTATE_WAKE_REASON_RING">
+		<TELC:sample name="DIE_CSTATE_WAKE_REASON_RING" datatypeIDREF="tdiec_wake_cause" sampleID="DIE_CSTATE_WAKE_REASON_RING">
 			<TELC:description>Die C-state wake due to SNOOP</TELC:description>
 			<TELC:sampleSubGroup>DIE_CSTATE_WAKE_REASON_RING</TELC:sampleSubGroup>
 			<TELC:sampleType>Counter</TELC:sampleType>
 			<TELC:size>32</TELC:size>
 			<TELC:lsb>0</TELC:lsb>
 			<TELC:msb>31</TELC:msb>
 		</TELC:sample>
-		<TELC:sample name="DIE_CSTATE_WAKE_REASON_SB" datatypeIDREF="tpkgc_wake_cause" sampleID="DIE_CSTATE_WAKE_REASON_SB">
+		<TELC:sample name="DIE_CSTATE_WAKE_REASON_SB" datatypeIDREF="tdiec_wake_cause" sampleID="DIE_CSTATE_WAKE_REASON_SB">
 			<TELC:description>Die C-state wake due to any SB transaction</TELC:description>
 			<TELC:sampleSubGroup>DIE_CSTATE_WAKE_REASON_SB</TELC:sampleSubGroup>
 			<TELC:sampleType>Counter</TELC:sampleType>
@@ -129,15 +129,15 @@
 	<TELEM:SampleGroup name="Container_6" sampleID="6" sampleGroupID="Container_6">
 		<TELC:description>Groupname 0x16030</TELC:description>
 		<TELC:length>64</TELC:length>
-		<TELC:sample name="DIE_CSTATE_WAKE_REASON_CORE" datatypeIDREF="tpkgc_wake_cause" sampleID="DIE_CSTATE_WAKE_REASON_CORE">
+		<TELC:sample name="DIE_CSTATE_WAKE_REASON_CORE" datatypeIDREF="tdiec_wake_cause" sampleID="DIE_CSTATE_WAKE_REASON_CORE">
 			<TELC:description>Die C-state wake due to TIMER expiry</TELC:description>
 			<TELC:sampleSubGroup>DIE_CSTATE_WAKE_REASON_CORE</TELC:sampleSubGroup>
 			<TELC:sampleType>Counter</TELC:sampleType>
 			<TELC:size>32</TELC:size>
 			<TELC:lsb>0</TELC:lsb>
 			<TELC:msb>31</TELC:msb>
 		</TELC:sample>
-		<TELC:sample name="BLOCK_CAUSE_CATEGORY_TIMER" datatypeIDREF="tpkgc_block_cause" sampleID="BLOCK_CAUSE_CATEGORY_TIMER">
+		<TELC:sample name="BLOCK_CAUSE_CATEGORY_TIMER" datatypeIDREF="tdiec_block_cause" sampleID="BLOCK_CAUSE_CATEGORY_TIMER">
 			<TELC:description>Counts the number of 1ms intervals during which DieC entry was blocked at least once by TIMER.</TELC:description>
 			<TELC:sampleSubGroup>BLOCK_CAUSE_CATEGORY_TIMER</TELC:sampleSubGroup>
 			<TELC:sampleType>Counter</TELC:sampleType>
@@ -149,15 +149,15 @@
 	<TELEM:SampleGroup name="Container_7" sampleID="7" sampleGroupID="Container_7">
 		<TELC:description>Groupname 0x16038</TELC:description>
 		<TELC:length>64</TELC:length>
-		<TELC:sample name="BLOCK_CAUSE_CATEGORY_DEMOTION" datatypeIDREF="tpkgc_block_cause" sampleID="BLOCK_CAUSE_CATEGORY_DEMOTION">
+		<TELC:sample name="BLOCK_CAUSE_CATEGORY_DEMOTION" datatypeIDREF="tdiec_block_cause" sampleID="BLOCK_CAUSE_CATEGORY_DEMOTION">
 			<TELC:description>Counts the number of 1ms intervals during which DieC entry was blocked at least once by DEMOTION.</TELC:description>
 			<TELC:sampleSubGroup>BLOCK_CAUSE_CATEGORY_DEMOTION</TELC:sampleSubGroup>
 			<TELC:sampleType>Counter</TELC:sampleType>
 			<TELC:size>32</TELC:size>
 			<TELC:lsb>0</TELC:lsb>
 			<TELC:msb>31</TELC:msb>
 		</TELC:sample>
-		<TELC:sample name="BLOCK_CAUSE_CATEGORY_MISC" datatypeIDREF="tpkgc_block_cause" sampleID="BLOCK_CAUSE_CATEGORY_MISC">
+		<TELC:sample name="BLOCK_CAUSE_CATEGORY_MISC" datatypeIDREF="tdiec_block_cause" sampleID="BLOCK_CAUSE_CATEGORY_MISC">
 			<TELC:description>Counts the number of 1ms intervals during which DieC entry was blocked at least once by MISC.</TELC:description>
 			<TELC:sampleSubGroup>BLOCK_CAUSE_CATEGORY_MISC</TELC:sampleSubGroup>
 			<TELC:sampleType>Counter</TELC:sampleType>
@@ -169,15 +169,15 @@
 	<TELEM:SampleGroup name="Container_8" sampleID="8" sampleGroupID="Container_8">
 		<TELC:description>Groupname 0x16040</TELC:description>
 		<TELC:length>64</TELC:length>
-		<TELC:sample name="BLOCK_CAUSE_CATEGORY_IP_BUSY" datatypeIDREF="tpkgc_block_cause" sampleID="BLOCK_CAUSE_CATEGORY_IP_BUSY">
+		<TELC:sample name="BLOCK_CAUSE_CATEGORY_IP_BUSY" datatypeIDREF="tdiec_block_cause" sampleID="BLOCK_CAUSE_CATEGORY_IP_BUSY">
 			<TELC:description>Counts the number of 1ms intervals during which DieC entry was blocked at least once by IP_BUSY.</TELC:description>
 			<TELC:sampleSubGroup>BLOCK_CAUSE_CATEGORY_IP_BUSY</TELC:sampleSubGroup>
 			<TELC:sampleType>Counter</TELC:sampleType>
 			<TELC:size>32</TELC:size>
 			<TELC:lsb>0</TELC:lsb>
 			<TELC:msb>31</TELC:msb>
 		</TELC:sample>
-		<TELC:sample name="BLOCK_CAUSE_CATEGORY_HYSTERSIS" datatypeIDREF="tpkgc_block_cause" sampleID="BLOCK_CAUSE_CATEGORY_HYSTERSIS">
+		<TELC:sample name="BLOCK_CAUSE_CATEGORY_HYSTERSIS" datatypeIDREF="tdiec_block_cause" sampleID="BLOCK_CAUSE_CATEGORY_HYSTERSIS">
 			<TELC:description>Counts the number of 1ms intervals during which DieC entry was blocked at least once by HYSTERESIS.</TELC:description>
 			<TELC:sampleSubGroup>BLOCK_CAUSE_CATEGORY_HYSTERSIS</TELC:sampleSubGroup>
 			<TELC:sampleType>Counter</TELC:sampleType>