Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared-types,ui-buttons): add theme variables for default and hover states for buttons #1840

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HerrTopi
Copy link
Contributor

@HerrTopi HerrTopi commented Jan 7, 2025

Closes: INSTUI-4421

@HerrTopi HerrTopi requested review from matyasf and joyenjoyer January 7, 2025 17:35
Copy link

github-actions bot commented Jan 7, 2025

PR Preview Action v1.5.0
🚀 Deployed preview to https://instructure.github.io/instructure-ui/pr-preview/pr-1840/
on branch gh-pages at 2025-01-08 16:04 UTC

@matyasf
Copy link
Collaborator

matyasf commented Jan 8, 2025

Can you expand the example here? https://instructure.design/pr-preview/pr-1840/#Button/#Styling%20buttons

Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Contributor

@joyenjoyer joyenjoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants