Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared-types,ui-options,ui-select): allow to change font weight … #1824

Merged

Conversation

ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Dec 11, 2024

…of selected option item in Select

Closes: INSTUI-4394

ISSUE:

  • In Select, the selected option's fontweight from the dropdown list cannot be changed (CLX team request)

TEST PLAN:

  • wrap the examples in Select inside the InstUISettingsProvider below
<InstUISettingsProvider
      theme={{
        componentOverrides: {
          'Options.Item' : { fontWeightSelected: 100 }
        }
      }}
    >
      SELECT COMPONENT
</InstUISettingsProvider>
  • change the value of fontWeightSelected e.g. 100, 900, or 'bold'
  • the fontWeight of the selected option from the dropdown should be changed accordingly

…of selected option item in Select

Closes: INSTUI-4394
Copy link

github-actions bot commented Dec 11, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-12 20:06 UTC

@ToMESSKa ToMESSKa self-assigned this Dec 11, 2024
@ToMESSKa ToMESSKa requested review from HerrTopi and matyasf December 11, 2024 16:45
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@HerrTopi HerrTopi merged commit 6818928 into master Dec 12, 2024
10 of 11 checks passed
@HerrTopi HerrTopi deleted the INSTUI-4394_allow_to_bold_text_in_select_option_items branch December 12, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants