Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(many): make meta package export everything which is exported in… #1823

Merged
merged 1 commit into from
Dec 12, 2024
Merged

chore(many): make meta package export everything which is exported in… #1823

merged 1 commit into from
Dec 12, 2024

Conversation

ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Dec 11, 2024 •
edited
Loading

… components

Closes: INSTUI-4381

  • added everything to the meta file which is exported in the ui-component-name/src/index.ts files
  • also added sub component exports to some of the ui-component-name/src/index.ts files where the sub components props were exported but not the sub components themselves (eg, AppNavItem was missing from AppNav)

@ToMESSKa ToMESSKa self-assigned this Dec 11, 2024
@ToMESSKa ToMESSKa requested review from matyasf and balzss December 11, 2024 16:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://instructure.github.io/instructure-ui/pr-preview/pr-1823/
on branch gh-pages at 2024-12-12 15:28 UTC

matyasf
matyasf approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@matyasf matyasf force-pushed the INSTUI-4381_export_ts_types_like_props_from_our_ui_meta_package branch from 3b95a64 to 4898338 Compare December 12, 2024 15:22
@matyasf
Copy link
Collaborator

matyasf commented Dec 12, 2024

FYI i've changed commit type to feat

@matyasf matyasf merged commit dee9abb into master Dec 12, 2024
8 checks passed
@matyasf matyasf deleted the INSTUI-4381_export_ts_types_like_props_from_our_ui_meta_package branch December 12, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balzss balzss balzss approved these changes

@matyasf matyasf matyasf approved these changes

Assignees

@ToMESSKa ToMESSKa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ToMESSKa @matyasf @balzss