Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add list markup for sidebar navigation sections children #1820

Merged
merged 1 commit into from
Dec 13, 2024
Merged

chore: add list markup for sidebar navigation sections children #1820

merged 1 commit into from
Dec 13, 2024

Conversation

ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Dec 11, 2024 •
edited
Loading

Closes: INSTUI-4244

ISSUE:

  • side navbar menu sections' children don't have a list markup despite appearing as a list

TEST PLAN:

  • open side navigation on the documentation page
  • inspect a section's children. eg, 'Usage', 'Accessibilty' and 'Themes' inside of 'Getting started' section
  • the section's children should have a list markup
  • screenreaders should announce these element as list
  • visually it should have no difference from previous version

@ToMESSKa ToMESSKa self-assigned this Dec 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-13 16:58 UTC

@ToMESSKa ToMESSKa requested review from matyasf and HerrTopi December 11, 2024 16:24
@HerrTopi HerrTopi merged commit e1142e4 into master Dec 13, 2024
11 checks passed
@HerrTopi HerrTopi deleted the INSTUI-4244_docs_use_list_html_markup_for_the_sidebar_menu branch December 13, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HerrTopi HerrTopi HerrTopi approved these changes

@matyasf matyasf matyasf approved these changes

Assignees

@ToMESSKa ToMESSKa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ToMESSKa @matyasf @HerrTopi