Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(link): add textUnderlineOffset to Link component theme override #1817

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

igera93
Copy link
Contributor

@igera93 igera93 commented Dec 9, 2024

Added text-underline-offset option to theme override variables.
Default value is set to auto.

Screenshot 2024-12-09 at 15 14 24 Screenshot 2024-12-09 at 15 07 46

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@igera93 igera93 self-assigned this Dec 9, 2024
@igera93 igera93 requested review from HerrTopi and a team December 9, 2024 14:16
Copy link

github-actions bot commented Dec 9, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-10 13:18 UTC

Copy link
Contributor

@HerrTopi HerrTopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@HerrTopi HerrTopi merged commit 2b2a997 into master Dec 10, 2024
10 of 11 checks passed
@HerrTopi HerrTopi deleted the feat/CLX-256-add-underline-offset-option-to-link branch December 10, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants