Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-source-code-editor): prevent Vite from erroring out during the… #1797

Merged

Conversation

ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Nov 27, 2024

… build in React 16/17

Closes: INSTUI-4382

ISSUE: Vite errors out during build for an unused dependency imported with import(). Possible solution: vitejs/vite#6582 (comment)

TEST PLAN:

@ToMESSKa ToMESSKa self-assigned this Nov 27, 2024
Copy link

github-actions bot commented Nov 27, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-28 13:49 UTC

Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

Copy link
Contributor

@joyenjoyer joyenjoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work Tamas!

@ToMESSKa ToMESSKa merged commit c871244 into master Nov 28, 2024
11 checks passed
@ToMESSKa ToMESSKa deleted the INSTUI-4382_vite_compilation_fails_when_using_react_16_or_17 branch November 28, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants