Skip to content

Commit

Permalink
docs: change port of localhost to 9090
Browse files Browse the repository at this point in the history
Canvas webUI runs on 8080 as well as our docs app. We should be able to run them at the same time
  • Loading branch information
HerrTopi committed Dec 2, 2024
1 parent c3f5f37 commit 2586791
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 11 deletions.
6 changes: 3 additions & 3 deletions docs/contributor-docs/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Please follow the steps on the [how to build guide page](#building-instui).
### Development

1. Run `npm run build:watch` to build all of the packages for a development environment and watch for changes.
1. Run `npm run dev` to start the dev server to run/develop examples and documentation. You can then visit [http://localhost:8080](http://localhost:8080) in a browser. When you make changes to the source code you should see the page auto-reload.
1. Run `npm run dev` to start the dev server to run/develop examples and documentation. You can then visit [http://localhost:9090](http://localhost:9090) in a browser. When you make changes to the source code you should see the page auto-reload.
1. Run `npm run test:watch -- --scope @instructure/[package name]` to run the tests for 'package name' and watch for changes.
1. Run `npm run test` to run all the tests for every package.

Expand Down Expand Up @@ -79,7 +79,7 @@ Please update the documentation and examples with any changes.
2. Add the dependency in `packages/__docs__/package.json`.
3. Add the reference in `packages/__docs__/tsconfig.build.json`.
6. Stop the dev server (if you have it running), and run `npm run dev` to pick up the new package.
7. Visit [http://localhost:8080](http://localhost:8080) in a browser. You should see your package listed in the docs.
7. Visit [http://localhost:9090](http://localhost:9090) in a browser. You should see your package listed in the docs.

### Adding a component

Expand All @@ -99,7 +99,7 @@ Please update the documentation and examples with any changes.
8. Run `npm run bootstrap` to generate the `es`, `lib` and `types` directories for your component.
9. Add your component to `packages/__docs__/components.js`.
10. Stop the dev server (if you have it running), and run `npm run dev` to pick up the new component.
11. Visit [http://localhost:8080](http://localhost:8080) in a browser. You should see your component listed in the docs.
11. Visit [http://localhost:9090](http://localhost:9090) in a browser. You should see your component listed in the docs.
12. Start making changes to your component, and watch it update in the browser automatically.
13. Resolve all `FIXME` comments in the generated code (except in the `MyComponentLocator.ts`).

Expand Down
2 changes: 1 addition & 1 deletion docs/contributor-docs/dev-commands.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ This is a quick developer reference for common Instructure UI repository command
| Command | Description |
| ----------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `npm run bootstrap` | Clean all node modules and build output, reinstall dependencies, create fresh build including regenerating design tokens and type declaration files. |
| `npm run dev` | Run a local instance of the documentation app in dev mode. Docs will be served at `http://0.0.0.0:8080` |
| `npm run dev` | Run a local instance of the documentation app in dev mode. Docs will be served at `http://0.0.0.0:9090` |
| `npm run start` | Run a local instance of the documentation app in production mode. The urls where the docs are being served will be included in the output of this command. |
| `npm run build` | Run the build command for all Instructure UI packages. Similar to bootstrap, but without the cleaning steps, installation of dependencies, and without the token and type generation. |
| `npm run build:watch` | Identical to `npm run build` but will watch for changes. Note: this command is rarely necessary to use. If you are running `npm run dev`, the docs app will already be watching for any changes for components. |
Expand Down
2 changes: 1 addition & 1 deletion packages/__docs__/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ From the root of the `instructure-ui` repo:

1. Run `npm install`
1. Run `npm run dev`
1. Open [http://localhost:8080](http://localhost:8080) in your browser
1. Open [http://localhost:9090](http://localhost:9090) in your browser
2 changes: 1 addition & 1 deletion packages/__docs__/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"scripts": {
"prestart": "npm run build:scripts:ts && node lib/build-docs.mjs",
"start": "npm run prestart && ui-scripts bundle && ui-scripts server -p 8001",
"start:watch": "npm run prestart && ui-scripts bundle --watch -p 8080",
"start:watch": "npm run prestart && ui-scripts bundle --watch -p 9090",
"bundle": "npm run prestart && ui-scripts bundle",
"lint": "ui-scripts lint",
"lint:fix": "ui-scripts lint --fix",
Expand Down
4 changes: 2 additions & 2 deletions packages/ui-scripts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Deprecates ALL of a certain version of instUI npm packages by running `npm depre

To build component examples and start up a dev server with hot reloading:

`npm run ui-scripts examples --watch -p 8080`
`npm run ui-scripts examples --watch -p 9090`

To build component examples for deploying:

Expand Down Expand Up @@ -98,7 +98,7 @@ To publish all packages (defaults to current version):

To start up a server to test production builds of examples or docs:

`npm run ui-scripts server -p 8080`
`npm run ui-scripts server -p 9090`

#### npm tag

Expand Down
2 changes: 1 addition & 1 deletion packages/ui-scripts/lib/build/examples.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default {
alias: 'p',
type: 'number',
describe: 'port to use',
default: 8080
default: 9090
})
yargs.option('watch', {
boolean: true,
Expand Down
2 changes: 1 addition & 1 deletion packages/ui-scripts/lib/build/webpack.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export default {
handler: async (argv) => {
const { NODE_ENV, DEBUG, OMIT_INSTUI_DEPRECATION_WARNINGS } = process.env

let port = argv.port || '8080'
let port = argv.port || '9090'

let command, webpackArgs

Expand Down
2 changes: 1 addition & 1 deletion packages/ui-scripts/lib/commands/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export default {
alias: 'p',
type: 'number',
describe: 'port to use.',
default: 8080
default: 9090
}
},
handler: (argv) => {
Expand Down

0 comments on commit 2586791

Please sign in to comment.