Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi keychain support #3

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

davidpelaez
Copy link

Hi.

Thanks for creating this tools. It looks very clever and simple to me. We need to have more than one keychain in use because of different security levels in our company. I added this. Mainly I picked a notation of keychain:account. I think the best way to see the changes is to go into the updated readme.

In the beginning I started working on the cloned master, so the history might be weird. I'm still learning a lot and I'm not sure my code is as clean as yours, but this might be useful code to include in the main gem.

Let me know what you think. Cheers,

DPT

prefs = JSON.parse(File.read(PREFS_FILE))
Keychain.open(prefs['aws_keychain_name'])
else
Keychain.default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to take this out?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to reply. I did mean to take it out. Since the
process of loading a keychain needed some changes (because you can now pass
the name of the keychain to load as a parameter) and because some
informative messages required the keychain of the prefs_file I moved it out
so that you can reaed the content of the configs globally. This is useful
to set the default keychain or create the default content of the file if
it's empty.

Does this solve the question? What are your impressions so far?

On Wed, May 8, 2013 at 11:29 AM, Cody Cutrer [email protected]:

In bin/aws-creds:

-def load_keychain

  • keychain = if File.exist? PREFS_FILE
  • prefs = JSON.parse(File.read(PREFS_FILE))
  • Keychain.open(prefs['aws_keychain_name'])
  • else
  • Keychain.default

Did you mean to take this out?


Reply to this email directly or view it on GitHubhttps://github.com//pull/3/files#r4137657
.

David Peláez Tamayo
Designer & Entrepreneur

@zwily
Copy link
Contributor

zwily commented Mar 21, 2016

Does anyone want to try rebasing this on top of current master?

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants