-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service entries #201
base: main
Are you sure you want to change the base?
Add service entries #201
Conversation
61f8cea
to
5a9fdcc
Compare
Signed-off-by: Milica Cvrkota <[email protected]>
5a9fdcc
to
230ddc7
Compare
controllers/util.go
Outdated
return false | ||
} | ||
|
||
return strings.Contains(meshConfig, "REGISTRY_ONLY") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would the configmap content look like, is a string.Contains a safe check here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got the message via Slack (thanks).
$ k get cm istio -o yaml
apiVersion: v1
data:
mesh: |-
accessLogFile: /dev/stdout
defaultConfig:
discoveryAddress: istiod.istio-system.svc:15012
proxyMetadata: {}
tracing:
zipkin:
address: zipkin.istio-system:9411
defaultProviders:
metrics:
- prometheus
enablePrometheusMerge: true
extensionProviders:
- envoyOtelAls:
port: 4317
service: opentelemetry-collector.istio-system.svc.cluster.local
name: otel
- name: skywalking
skywalking:
port: 11800
service: tracing.istio-system.svc.cluster.local
- name: otel-tracing
opentelemetry:
port: 4317
service: opentelemetry-collector.otel-collector.svc.cluster.local
outboundTrafficPolicy:
mode: REGISTRY_ONLY
rootNamespace: istio-system
trustDomain: cluster.local
meshNetworks: 'networks: {}'
kind: ConfigMap
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"v1","data":{"mesh":"accessLogFile: /dev/stdout\ndefaultConfig:\n discoveryAddress: istiod.istio-system.svc:15012\n proxyMetadata: {}\n tracing:\n zipkin:\n address: zipkin.istio-system:9411\ndefaultProviders:\n metrics:\n - prometheus\nenablePrometheusMerge: true\nextensionProviders:\n- envoyOtelAls:\n port: 4317\n service: opentelemetry-collector.istio-system.svc.cluster.local\n name: otel\n- name: skywalking\n skywalking:\n port: 11800\n service: tracing.istio-system.svc.cluster.local\n- name: otel-tracing\n opentelemetry:\n port: 4317\n service: opentelemetry-collector.otel-collector.svc.cluster.local\noutboundTrafficPolicy:\n mode: REGISTRY_ONLY\nrootNamespace: istio-system\ntrustDomain: cluster.local","meshNetworks":"networks: {}"},"kind":"ConfigMap","metadata":{"annotations":{},"labels":{"install.operator.istio.io/owning-resource":"unknown","install.operator.istio.io/owning-resource-namespace":"istio-system","istio.io/rev":"default","operator.istio.io/component":"Pilot","operator.istio.io/managed":"Reconcile","operator.istio.io/version":"1.18.0","release":"istio"},"name":"istio","namespace":"istio-system"}}
creationTimestamp: "2024-08-05T12:31:26Z"
labels:
install.operator.istio.io/owning-resource: unknown
install.operator.istio.io/owning-resource-namespace: istio-system
istio.io/rev: default
operator.istio.io/component: Pilot
operator.istio.io/managed: Reconcile
operator.istio.io/version: 1.18.0
release: istio
name: istio
namespace: istio-system
resourceVersion: "436321423"
uid: 432e0200-90d6-443c-b87e-2cbd8de5f467
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would propose to exactly check outboundTrafficPolicy: mode: REGISTRY_ONLY
in that case.
Is that string always uppercase?
bf58b7a
to
0edba70
Compare
0edba70
to
3464ea6
Compare
No description provided.