dedupers: allow deduping all lists recursively #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michamos
force-pushed
the
add-dedupe-all
branch
from
3370338 to
e188e41
Compare
michamos
force-pushed
the
add-dedupe-all
branch
from
e188e41 to
0d623ee
Compare
michamos
force-pushed
the
add-dedupe-all
branch
from
0d623ee to
e6f13f1
Compare
drjova
reviewed
Nov 22, 2023
| exclude_keys (Container[str]): key names to ignore for deduplication | ||
| dedupe_top_level (bool): whether the top-level list should be deduplicated too | ||
| """ | ||
| squared_dedupe_len = 10 |
There was a problem hiding this comment.
would it make sense to have this configurable?
There was a problem hiding this comment.
would it? is anyone going to run microbenchmarks to optimize this value for each specific use case? it's just a performance optimization (that I copied over from inspire-dojson), it doesn't affect the results.
drjova
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.