Merge pull request #439 from MJedr/fix-add-documents

add fulltext property to documents if it is false
inspirehep · Nov 2, 2022 · e9d64cb · e9d64cb
2 parents 779702c + 461e5ff
commit e9d64cb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/inspire_schemas/builders/literature.py b/inspire_schemas/builders/literature.py
@@ -933,7 +933,7 @@ def add_document(self, key, url, **kwargs):
             'url',
             'filename',
         ):
-            if kwargs.get(dict_key):
+            if kwargs.get(dict_key) is not None:
                 document[dict_key] = kwargs[dict_key]
 
         if key_already_there(document, self.record.get('documents', ())):

diff --git a/tests/unit/test_literature_builder.py b/tests/unit/test_literature_builder.py
@@ -255,7 +255,7 @@ def test_add_document():
     builder.add_document(
         'key',
         description='description',
-        fulltext=True,
+        fulltext=False,
         hidden=True,
         material='preprint',
         original_url='http://www.example.com/original_url',
@@ -267,7 +267,7 @@ def test_add_document():
     expected = [
         {
             'description': 'description',
-            'fulltext': True,
+            'fulltext': False,
             'hidden': True,
             'key': 'key',
             'material': 'preprint',