Modifications in ETS for issues #180, #189 and #182

[inakidiazdecerio]

Pull requests:

• Modifications in the ETS to solve the issue #180 #191
• Modifications in the ETS to solve the issue #189 #190
• Modifications in the ETS to solve the issue #182 #192

[michellutz]

The idea was to have bugfix releases deployed first on a test server, before we merge them into the master branch and deploy them into production. Since we don't yet have a testing server, how could we proceed? Could you deploy the bugfix release on your testing server, so we can try out the behaviour?

[inakidiazdecerio]

Dear @michellutz,
Changes were deployed in following server (our premises):
http://sc01etfstaging.desarrollo.guadaltel.es/etf-webapp-bugfix/
It is pending to be accepted.

[MarcoMinghini]

I compared the outcome of the tests executed on the bugfix release (testing server) and the ETF Validator for each of the resources (metadata and data sets) involved in the 3 issues. All the issues are solved.

[MarcoMinghini]

Dear @inakidiazdecerio, following the new issue on the community space https://github.com/inspire-eu-validation/community/issues/30, we noticed that the edit to the code for solving #180 is probably not the one that was agreed.

The assertion should check that the codeListValue attribute is "publication" AND ALSO that there is actually a non-empty value of the element <CI_DateTypeCode>.

We noticed that because the validation of the metadata mentioned in https://github.com/inspire-eu-validation/community/issues/30 in the staging instance passes. Instaed, it should not pass because there is no value 'publication' (i.e. there is an empty value) for the element <gmd:CI_DateTypeCode>.

Can you make a new PR to solve this?

[inakidiazdecerio]

Thank you @MarcoMinghini for your comments. We will make a pull request including the non-empty check.

Best regards.

[MarcoMinghini]

The pull request was made and accepted.