Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of CRS element from ISO 19115 community profile XML document #184

Open
enricoboldrini opened this issue Oct 12, 2018 · 7 comments
Labels
solved Solution developed and accepted, not yet deployed

Comments

@enricoboldrini
Copy link

Error returned: The metadata record does not specify the coordinate reference system(s) used in the dataset.

I'm validating a SeaDataNet XML document, that is a community profile of ISO 19115 metadata (https://www.seadatanet.org/Standards/Metadata-formats/CDI), drafted according to official ISO 19115 rules.
Actually the CRS is specified in the document, at XPath: gmd:referenceSystemInfo/gmd:MD_ReferenceSystem/gmd:referenceSystemIdentifier/gmd:RS_Identifier/gmd:code/sdn:SDN_CRSCode
Most likely, the test expects gco:CharacterString instead of the codelist sdn:SDN_CRSCode that is a community defined code list.

@enricoboldrini
Copy link
Author

Hello, I've noticed the planned tag has been added. Can you elaborate more on the planning schedule for this issue? Thank you in advance. Please let me know if more info are needed.

@enricoboldrini
Copy link
Author

In the meantime an updated version of SeaDataNet community profile has been released. Here are the updated test reports:

@MarieLambois
Copy link

Again an issue with extensions. There is no interest in testing that the type is gco:CharacterString. It could be many other things (such as Anchor). The test should be made on:
gmd:referenceSystemInfo//gmd:referenceSystemIdentifier//gmd:code/*

@AntoRot
Copy link

AntoRot commented May 22, 2019

No reference to the use of gco:CharacterString is made in the TG req 2.1, but only to the child elements of gmd:RS_Identifier 'gmd:code' (mandatory) and 'gmd:codeSpace' (optional). So, I agree with @MarieLambois that the test should be made on gmd:referenceSystemInfo//gmd:referenceSystemIdentifier//gmd:code/* and in case on gmd:referenceSystemInfo//gmd:referenceSystemIdentifier//gmd:codeSpace/* consistently with the mentioned TG req 2.1.

@enricoboldrini
Copy link
Author

This is now solved, thank you! However the value in the metadata document is: "World Geodetic System 84", and as I understand only URI identifiers from the table at https://inspire.ec.europa.eu/documents/Data_Specifications/INSPIRE_DataSpecification_Template_v3.0rc3.pdf are considered valid (e.g. http://www.opengis.net/def/crs/EPSG/0/4258). Are there any possibilities that this constraint will be relaxed in the near future, in particular to accomodate EPSG:4326?

@MarcoMinghini MarcoMinghini added solved Solution developed and accepted, not yet deployed and removed planned labels May 23, 2019
@michellutz
Copy link

I am a bit surprised that the ATS and ETS for the interoperability metadata still has the checks for specific CRSs in. We agreed a long time ago (see https://themes.jrc.ec.europa.eu/discussion/view/64808/what-crss-to-document-in-metadata-when-serving-a-dataset-through-a-wfs) that the obligation on metadata is only to provide the CRS metadata element (with the source CRS the data set is originally published in).

The obligation to publish the data in an INSPIRE CRS is checked in this data test: https://github.com/inspire-eu-validation/data/blob/3.0rc3/reference-systems/spatial.md

Also in the MD v2.0 tests, the CRSs are not checked for this element. So I think the test in https://github.com/inspire-eu-validation/data/blob/master/interoperability-metadata/coordinate-reference-system.md and the corresponding ETS should be updated (to remove the check for specific CRSs).

@michellutz michellutz added for-2017.4-discussion and removed solved Solution developed and accepted, not yet deployed labels May 24, 2019
@AntoRot
Copy link

AntoRot commented May 24, 2019

I checked the file used for validation and I noticed that the error returned on the CRS metadata element doesn't concern the value of the identifier (see Assertion URI http://staging-inspire-validator.eu-west-1.elasticbeanstalk.com/etf-webapp/v2/TestRuns/EID94ada6ca-9754-42f5-a86c-4bfe4904f99e.html?lang=it#EIDea254806-f3f2-402a-b5ab-ce559989163a), but it concerns the test https://github.com/inspire-eu-validation/metadata/blob/2.0/isdss/crs.md on the existence of at least one RS_Identifier element and one Code element (see Assertion URI http://staging-inspire-validator.eu-west-1.elasticbeanstalk.com/etf-webapp/v2/TestRuns/EID94ada6ca-9754-42f5-a86c-4bfe4904f99e.html?lang=it#EIDd06cc736-39c8-4828-88dc-30a62d4ee09f), although those elements are included in the record.
I think that is due to the check on the presence of gco:CharacterString or gmx:Anchor as child elements of the Code element, while in the record a code list is used. So, the test should be relaxed consequently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved Solution developed and accepted, not yet deployed
Projects
None yet
Development

No branches or pull requests

6 participants