Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of metadata document of ISO 19115 profile (SeaDataNet profile) #45

Closed
enricoboldrini opened this issue Apr 30, 2019 · 14 comments
Assignees
Labels
deployed in reference validator Solution deployed in production

Comments

@enricoboldrini
Copy link

I'm validating a SeaDataNet XML document, that is a community profile of ISO 19115 metadata (https://www.seadatanet.org/Standards/Metadata-formats/CDI), drafted according to official ISO 19115 rules.
I've found some specific issues executing the metadata related tests, so I opened the following sub-issues:
https://github.com/inspire-eu-validation/ets-repository/issues/183
inspire-eu-validation/ets-repository#184
inspire-eu-validation/ets-repository#185

I've been glad to see that the issues have been lately tagged as "planned". Please let me know if more information/action is needed or could be useful from our side and if an expected schedule for the fix is available. Thanks.

@inakidiazdecerio
Copy link
Contributor

Dear @enricoboldrini,

Thank you for your explanations.

Regarding issue inspire-eu-validation/ets-repository#183, the error disappears if you add the namespace and schema location URI of 'gmd' in the attribute xsi:schemaLocation (see the attached image). For issues inspire-eu-validation/ets-repository#184 and inspire-eu-validation/ets-repository#185, we have been working in a possible solution. We included these two issues for discussion during next subgroup meeting where we will prioritize next developments.

We will come back to you when we have any news.

Regards.

image

@inakidiazdecerio inakidiazdecerio added the for-2017.4-discussion This issue will be discussed with the sub-group 2017.4 label May 2, 2019
@josemasensio
Copy link
Contributor

Dear @enricoboldrini,

We are happy to announce that the solution for this issue has been implemented in the INSPIRE Validator. The solution passed our quality controls, but we will appreciate if you could test it and give us some feedback. You can test the solution in the staging environment:

http://staging-inspire-validator.eu-west-1.elasticbeanstalk.com/etf-webapp/

Thanks in advance for your help.

@inakidiazdecerio inakidiazdecerio added ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing and removed for-2017.4-discussion This issue will be discussed with the sub-group 2017.4 labels May 23, 2019
@enricoboldrini
Copy link
Author

Thank you very much for having advanced the support for community profiles!
Here is the updated situation after some tests:

inspire-eu-validation/ets-repository#183
Error still present, I can't change the schema location, as the schemata used to validate the document are a super set of ISO 19139. Changing the schema location to ISO 19139 schemata only, it will not validate any more community extensions.

inspire-eu-validation/ets-repository#184
The CRS code is now correctly tested. However EPSG:4326 seems not to be supported. Are there any plans to support it?

inspire-eu-validation/ets-repository#185
Solved!

Thank you for the effort, I hope the remaining issues will be closed soon.

@josemasensio
Copy link
Contributor

@enricoboldrini thank you for your feedback. About the issues:

inspire-eu-validation/ets-repository#183
If the XML doesn't have the namespace and the schema location URI of 'gmd' in xsi:schemaLocation attribute, the error will not be solved.

inspire-eu-validation/ets-repository#184
The test checks that the CRS code has one of the following values:
'http://www.opengis.net/def/crs/EPSG/0/4936', 'http://www.opengis.net/def/crs/EPSG/0/4937', 'http://www.opengis.net/def/crs/EPSG/0/4258', 'http://www.opengis.net/def/crs/EPSG/0/3035', 'http://www.opengis.net/def/crs/EPSG/0/3034', 'http://www.opengis.net/def/crs/EPSG/0/3038', 'http://www.opengis.net/def/crs/EPSG/0/3039', 'http://www.opengis.net/def/crs/EPSG/0/3040', 'http://www.opengis.net/def/crs/EPSG/0/3041', 'http://www.opengis.net/def/crs/EPSG/0/3042', 'http://www.opengis.net/def/crs/EPSG/0/3043', 'http://www.opengis.net/def/crs/EPSG/0/3044', 'http://www.opengis.net/def/crs/EPSG/0/3045', 'http://www.opengis.net/def/crs/EPSG/0/3046', 'http://www.opengis.net/def/crs/EPSG/0/3047', 'http://www.opengis.net/def/crs/EPSG/0/3048', 'http://www.opengis.net/def/crs/EPSG/0/3049', 'http://www.opengis.net/def/crs/EPSG/0/3050', 'http://www.opengis.net/def/crs/EPSG/0/3051', 'http://www.opengis.net/def/crs/EPSG/0/5730', 'http://www.opengis.net/def/crs/EPSG/0/7409'
In your XML file the CRS code has the value 'World Geodetic System 84', this is why the test fails. @MarcoMinghini the test will support other values in the CRS code for a SeaDataNet XML document?

Thank you and best regards.

@enricoboldrini
Copy link
Author

Thank you for the follow-up.

About inspire-eu-validation/ets-repository#183 I've changed the schema location to: xsi:schemaLocation="http://www.seadatanet.org http://schemas.seadatanet.org/Standards-Software/Metadata-formats/SDN2_CDI_ISO19139_11.0.0.xsd http://www.isotc211.org/2005/gmd http://schemas.opengis.net/iso/19139/20060504/gmd/gmd.xsd" and both passed the test and validated against community schemas, so this might be a viable workaround!

Please note that if the schemas are reversed in order the workaround will not work (this seems a bug in the validator). Example given, the following will not pass the test:
xsi:schemaLocation="http://www.isotc211.org/2005/gmd http://schemas.opengis.net/iso/19139/20060504/gmd/gmd.xsd http://www.seadatanet.org http://schemas.seadatanet.org/Standards-Software/Metadata-formats/SDN2_CDI_ISO19139_11.0.0.xsd">

However, it still seems strange to mandate http://schemas.opengis.net/iso/19139/20060504/gmd/gmd.xsd schema directly in the schema location (because that schema is being already imported by http://schemas.seadatanet.org/Standards-Software/Metadata-formats/SDN2_CDI_ISO19139_11.0.0.xsd). Let me know if you are willing to consider the resolution of imports in the near future, otherwise we will have to proceed with the suggested workaround.

Thank you very much for the productive discussion.

@josemasensio
Copy link
Contributor

@enricoboldrini the suggested solution looks fine to me.

Thank you and regards.

@MarcoMinghini
Copy link
Contributor

2017.4 meeting 2019-05-22

After the meeting and the discussion that followed, this is the summary:

  • #183: solved
  • #184: we keep the discussion open on whether the test should be relaxed (to allow not only gco:CharacterString or gmx:Anchor as child elements of the Code element)
  • #185: solved

@inakidiazdecerio inakidiazdecerio added the discussion This is a discussion about the Validator, any comment is welcome label May 28, 2019
@enricoboldrini
Copy link
Author

Great job, thanks. Could you provide some approximate date or steps needed for the resolution of issue inspire-eu-validation/ets-repository#184 ? Thank you very much,
Enrico

@josemasensio
Copy link
Contributor

josemasensio commented Jun 6, 2019

Dear @enricoboldrini,

The changes to solve the issue #184 are ready. You can test the solution in the staging environment:

http://staging-inspire-validator.eu-west-1.elasticbeanstalk.com/etf-webapp/

Some feedback from you will be very appreciated.

Thank you and best regards.

@inakidiazdecerio inakidiazdecerio removed the discussion This is a discussion about the Validator, any comment is welcome label Jun 6, 2019
@enricoboldrini
Copy link
Author

I confirm that change worked fine. Thank you very much! When the changes will be available in the official environment? (a rough estimate will be helpful as well)

@enricoboldrini
Copy link
Author

I have tested an additional metadata profile in use by the SeaDataNet community, called CSR. In this case the validator gives error during the upload file phase just at the beginning, preventing the actual tests to be executed. The cause could be that this profile uses as well the second part of ISO 19115 (ISO19115-2, gmi package). I'm attaching the file raising the issue.
inspire.zip

@josemasensio
Copy link
Contributor

@enricoboldrini could you open a new issue explaining the file upload problem?

@MarcoMinghini can we mark this issue and the #184 as solved?

@MarcoMinghini
Copy link
Contributor

Yes, I suggest to mark this issue as solved and I ask @enricoboldrini open a separate one for the new problem. Thank you.

@inakidiazdecerio inakidiazdecerio added solved Solution developed and accepted, not yet deployed and removed ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing labels Jun 13, 2019
@enricoboldrini
Copy link
Author

Sure, I've opened https://github.com/inspire-eu-validation/community/issues/65
Thank you again for the effort in solving the above issues.

@MarcoMinghini MarcoMinghini added this to the v 1.0.8 2019.11 milestone Nov 12, 2019
@josemasensio josemasensio added deployed in reference validator Solution deployed in production and removed solved Solution developed and accepted, not yet deployed labels Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed in reference validator Solution deployed in production
Projects
None yet
Development

No branches or pull requests

4 participants