Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUSPENDED: (PLAT-845) bootstrap and consensus uniproto, new branch #866

Open
wants to merge 18 commits into
base: network-transports
Choose a base branch
from

fix

fb7bcfb
Select commit
Loading
Failed to load commit list.
Open

SUSPENDED: (PLAT-845) bootstrap and consensus uniproto, new branch #866

fix
fb7bcfb
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable failed Sep 14, 2024 in 0s

2/3 Fail(s): TITLE, APPROVALS

Status: FAIL

    Here are some stats of the run:
    3 validations were ran.
    1 PASSED
    2 FAILED

Details

❌ Validator: TITLE

  • ✔️ title must exclude '\bWIP\b'
    Input : SUSPENDED: (PLAT-845) bootstrap and consensus uniproto, new branch
    Settings : {"must_exclude":{"regex":"\\bWIP\\b"}}
  • title does not include "^([A-Z][A-Z]+-\d+|NOISSUE|HOTFIX):"
    Input : SUSPENDED: (PLAT-845) bootstrap and consensus uniproto, new branch
    Settings : {"must_include":{"regex":"^([A-Z][A-Z]+-\\d+|NOISSUE|HOTFIX):","regex_flag":"none"}}

✔️ Validator: DESCRIPTION

  • ✔️ The description is not empty
    Input : what I did?

remove old transport
hostnetwork and futures refactoring, remove SendTo(reference), connecting pool, etc.
use nwapi.Address instead of legacy host
nwapi.Address serialization and test
register two protocols in uniproto dispatcher for consensus and bootstrap
switch pulsar to uniserver
switch bootstrap and consensus to uniproto
how to verify?

launchnet.sh local run
almost all tests are green =)
Settings : {"no_empty":{"enabled":true,"message":"Description matter and should not be empty. Provide detail with **what** was changed, **why** it was changed, and **how** it was changed."}}

❌ Validator: APPROVALS

  • ℹ️ Only approvals from following sources are counted
    Input :
    Settings : {"teams":["insolar/dev-core","insolar/devops"]}
  • A minimum of 2 approvals required.
    Input :
    Settings : {"min":{"count":2,"message":"A minimum of 2 approvals required."}}
  • ✔️ approvals: all required reviewers have approved
    Input :
    Settings : {"required":{"assignees":true,"message":"All assignees must approve this PR before merging."}}
  • ✔️ No Changes are Requested
    Input :
    Settings : {"changes_requested":true,"message":"Merge is blocked, changes requested."}