Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include refs for indirect deps #51

Merged
merged 4 commits into from
Jul 26, 2024
Merged

include refs for indirect deps #51

merged 4 commits into from
Jul 26, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Jul 24, 2024

this fixes the issue observed when testing on teal@479_mirai_pr
mirai@main requires dev version of nanonext. We recently added extra_deps parameter to be able to include this in the Imports but we also need to use Config/Needs/verdepcheck entry for these extra dependencies. Right now all additional entries are dropped in get_refs_from_desc(). The change is pretty simple - add extra deps before this function call.

@pawelru pawelru requested a review from averissimo July 24, 2024 13:13
@pawelru pawelru enabled auto-merge July 24, 2024 13:13
Copy link
Contributor

github-actions bot commented Jul 24, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -------------------------------------------
R/check.R                            73      73  0.00%    27-224
R/deps_installation_proposal.R      143     143  0.00%    62-280
R/desc_utils.R                       96      43  55.21%   15-32, 108, 117-122, 172, 195, 208-247, 265
R/get_ref.R                         239     238  0.42%    13-473, 492-535
R/solve.R                            84      84  0.00%    9-170
R/utils.R                            66      42  36.36%   3-23, 41, 47, 57-104
TOTAL                               701     623  11.13%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 2dc2ed4

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jul 24, 2024

Unit Tests Summary

 1 files   4 suites   2s ⏱️
45 tests 15 ✅ 30 💤 0 ❌
98 runs  67 ✅ 31 💤 0 ❌

Results for commit 2dc2ed4.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 24, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
deps_installation_proposal 👶 $+0.03$ indirect_dependencies_in_the_config_field_ignore_on_default
deps_installation_proposal 👶 $+0.03$ indirect_dependencies_in_the_config_field_include_on_match_with_extra_deps_

Results for commit 324ef06

♻️ This comment has been updated with latest results.

Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR to solve the problem! 2 comments:

  1. The testing method should be updated (get_fielt to get_list)
  2. I believe the logic on the second is not right

tests/testthat/test-deps_installation_proposal.R Outdated Show resolved Hide resolved
tests/testthat/test-deps_installation_proposal.R Outdated Show resolved Hide resolved
Co-authored-by: André Veríssimo <[email protected]>
Signed-off-by: Pawel Rucki <[email protected]>
@pawelru pawelru requested a review from averissimo July 26, 2024 08:56
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@pawelru pawelru merged commit 54ea47d into main Jul 26, 2024
29 checks passed
@pawelru pawelru deleted the fix_max_indirect branch July 26, 2024 11:13
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants