-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include refs for indirect deps #51
Conversation
Code Coverage Summary
Diff against main
Results for commit: 2dc2ed4 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 4 suites 2s ⏱️ Results for commit 2dc2ed4. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceAdditional test case details
Results for commit 324ef06 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR to solve the problem! 2 comments:
- The testing method should be updated (
toget_fielt
get_list
) - I believe the logic on the second is not right
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Pawel Rucki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
this fixes the issue observed when testing on
teal@479_mirai_pr
mirai@main
requires dev version ofnanonext
. We recently addedextra_deps
parameter to be able to include this in the Imports but we also need to useConfig/Needs/verdepcheck
entry for these extra dependencies. Right now all additional entries are dropped inget_refs_from_desc()
. The change is pretty simple - add extra deps before this function call.