Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement an alternative way of getting release date #42

Merged
merged 7 commits into from
Apr 19, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Apr 19, 2024

pkgcache stopped reporting publish date used as a release date used in min_cohort strategy. As a result, NA is used which makes max release date not correct.
I have reported this (linked issue) and the maintainer agreed it's an issue that needs a fix. Until this happen, please see this temporary workaround of scrapping it from CRAN webpage.

@Melkiades FYI: that's the root cause of the formatters issue we have observed

@pawelru pawelru requested a review from averissimo April 19, 2024 11:40
Copy link
Contributor

github-actions bot commented Apr 19, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ------------------------
R/check.R                            37      37  0.00%    26-170
R/deps_installation_proposal.R      139     139  0.00%    58-269
R/desc_utils.R                       70      42  40.00%   15-32, 108, 117-167, 185
R/get_ref.R                         218     217  0.46%    13-419, 435-467
R/solve.R                            81      81  0.00%    9-165
R/utils.R                            70      55  21.43%   3-22, 38-113
TOTAL                               615     571  7.15%

Diff against main

Filename                          Stmts    Miss  Cover
------------------------------  -------  ------  --------
R/deps_installation_proposal.R       +2      +2  +100.00%
R/get_ref.R                         +10     +10  -0.02%
TOTAL                               +12     +12  -0.14%

Results for commit: 07c97c0

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Apr 19, 2024

Unit Tests Summary

 1 files   4 suites   1s ⏱️
41 tests 13 ✅ 28 💤 0 ❌
94 runs  65 ✅ 29 💤 0 ❌

Results for commit 07c97c0.

♻️ This comment has been updated with latest results.

@pawelru pawelru enabled auto-merge April 19, 2024 12:09
R/get_ref.R Outdated Show resolved Hide resolved
@averissimo averissimo self-assigned this Apr 19, 2024
@pawelru pawelru disabled auto-merge April 19, 2024 12:52
@pawelru pawelru changed the title scrap published date if empty implement an alternative way of getting release date Apr 19, 2024
R/get_ref.R Outdated Show resolved Hide resolved
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Good thing you applied my original suggestion and not the edit 🤦

@pawelru pawelru merged commit 3452218 into main Apr 19, 2024
24 checks passed
@pawelru pawelru deleted the workaround_empty_release_date branch April 19, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants