Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add teal.plot_dpi option #26

Merged
merged 6 commits into from
May 12, 2022
Merged

add teal.plot_dpi option #26

merged 6 commits into from
May 12, 2022

Conversation

nikolas-burkoff
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff commented May 12, 2022

Closes #25 along with insightsengineering/teal#630 -> this is what was implemented

Test with:

library(shiny)
library(teal.widgets)

res <- 96
options(teal.plot_dpi = res)

shinyApp(
  ui = fluidPage(
    plot_with_settings_ui(
      id = "plot_with_settings"
    )
  ),
  server = function(input, output, session) {
    plot_r <- reactive({
      #plot(x = iris$Sepal.Length, y = iris$Sepal.Width)
      ggplot2::qplot(x = iris$Sepal.Length, y = iris$Sepal.Width)
    })
    plot_with_settings_srv(
      id = "plot_with_settings",
      plot_r = plot_r,
      height = c(400, 100, 1200),
      width = c(500, 250, 750)
    )
  }
)

and any other apps you feel like testing it with

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2022

Unit Tests Summary

  1 files    4 suites   1s ⏱️
45 tests 45 ✔️ 0 💤 0
87 runs  87 ✔️ 0 💤 0

Results for commit 0eae6f6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2022

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  ---------
R/accordion.R                 45      45  0.00%    12-62
R/basic_table_args.R          23       0  100.00%
R/get_dt_rows.R               13      13  0.00%    27-39
R/ggplot2_args.R              49       0  100.00%
R/include_css_js.R             7       7  0.00%    12-19
R/optionalInput.R            201     201  0.00%    77-457
R/panel_group.R               68      68  0.00%    15-127
R/plot_with_settings.R       377     371  1.59%    8-582
R/standard_layout.R           40       0  100.00%
R/table_with_settings.R      167     167  0.00%    11-236
R/white_small_well.R           5       5  0.00%    18-22
TOTAL                        995     877  11.86%

Results for commit: a2c5087

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@Polkas Polkas self-assigned this May 12, 2022
Copy link
Contributor

@Polkas Polkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Only one comment

R/plot_with_settings.R Outdated Show resolved Hide resolved
Nikolas Burkoff added 2 commits May 12, 2022 14:30
@nikolas-burkoff nikolas-burkoff merged commit 2236dd7 into main May 12, 2022
@nikolas-burkoff nikolas-burkoff deleted the 25dpi@main branch May 12, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default 72 dpi in renderPlot, where the common standard is 96
2 participants