Skip to content

Commit

Permalink
Adds min package version (#168)
Browse files Browse the repository at this point in the history
WIP :: parent issue:
insightsengineering/nestdevs-tasks#7

Supersede:
* https://github.com/insightsengineering/teal.logger/pull/159

### 🔴 Checklist for PR Reviewer

- [ ] Tag yourself next to this repo on
insightsengineering/nestdevs-tasks#7
- [ ] Package versions are the same or higher than `main`
- [ ] Package list is the same
  - Only exception is `rmarkdown` (may have been removed on `Suggests`)
- [ ] All packages in `Imports`, `Depends` & `Suggests` are in new
section `Config/Needs/verdepcheck`
- [ ] Added entry to `NEWS.md`
- [ ] Last `scheduled.yaml` action was run succesfully _(all 4
strategies)_
- important: it's not the last commit, it's the one that runs 4
`Scheduled 🕰️ / Dependency` actions
- [ ] `scheduled.yaml` SHOULD NOT have any push on any branches

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* `verdepcheck.yml` action (see comments)
  - [x] Remove `on: push` section 
  - [x] Change branch to main

#### PRS

- [x] verdepcheck
  * insightsengineering/verdepcheck#24
  * insightsengineering/verdepcheck#26
- [x] verdepcheck-action
  * insightsengineering/r-verdepcheck-action#16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action
  • Loading branch information
averissimo authored Sep 6, 2023
1 parent d34e23c commit a070556
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
test-strategy: ["min", "release", "max"]
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
secrets:
Expand Down
45 changes: 32 additions & 13 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -18,28 +18,47 @@ Depends:
R (>= 3.6)
Imports:
bslib,
checkmate,
ggplot2,
checkmate (>= 2.1.0),
ggplot2 (>= 3.4.0),
graphics,
grDevices,
htmltools,
lifecycle,
htmltools (>= 0.5.4),
lifecycle (>= 0.2.0),
methods,
rtables (>= 0.6.0.9004),
shiny,
shiny (>= 1.6.0),
shinyjs,
shinyWidgets,
styler
shinyWidgets (>= 0.5.1),
styler (>= 1.2.0)
Suggests:
knitr,
lattice,
magrittr,
knitr (>= 1.42),
lattice (>= 0.18-4),
magrittr (>= 1.5),
png,
rmarkdown,
shinytest2 (>= 0.2.0),
shinyvalidate,
testthat (>= 2.0),
withr
testthat (>= 3.0.4),
withr (>= 2.1.0)
Config/Needs/verdepcheck:
rstudio/bslib,
mllg/checkmate,
tidyverse/ggplot2,
rstudio/htmltools,
r-lib/lifecycle,
insightsengineering/rtables,
rstudio/shiny,
daattali/shinyjs,
dreamRs/shinyWidgets,
r-lib/styler,
yihui/knitr,
deepayan/lattice,
tidyverse/magrittr,
cran/png,
rstudio/shinytest2,
rstudio/shinyvalidate,
r-lib/testthat,
r-lib/withr
Config/Needs/website: insightsengineering/nesttemplate
VignetteBuilder:
knitr
Encoding: UTF-8
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

* Documentation enhancements - code formatting package names and R objects.
* Add `grDevices` to Imports.
* Specified minimal version of package dependencies.

# teal.widgets 0.4.0

Expand Down

0 comments on commit a070556

Please sign in to comment.