Skip to content

Commit

Permalink
Adds min package version (#150)
Browse files Browse the repository at this point in the history
WIP :: parent issue:
insightsengineering/nestdevs-tasks#7

Supersede:
* #137

### 🔴 Checklist for PR Reviewer

- [x] Tag yourself next to this repo on
insightsengineering/nestdevs-tasks#7
- [x] Package versions are the same or higher than `main`
- [x] Package list is the same
  - Only exception is `rmarkdown` (may have been removed on `Suggests`)
- [x] All packages in `Imports`, `Depends` & `Suggests` are in new
section `Config/Needs/verdepcheck`
- [x] Added entry to `NEWS.md`
- [x] Last `scheduled.yaml` action was run succesfully _(all 4
strategies)_
- important: it's not the last commit, it's the one that runs 4
`Scheduled 🕰️ / Dependency` actions
- [x] `scheduled.yaml` SHOULD NOT have any push on any branches

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* `verdepcheck.yml` action (see comments)
  - [x] Remove `on: push` section 
  - [x] Change branch to main

#### PRS

- [x] verdepcheck
  * insightsengineering/verdepcheck#24
  * insightsengineering/verdepcheck#26
- [x] verdepcheck-action
  * insightsengineering/r-verdepcheck-action#16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action

---------

Signed-off-by: André Veríssimo <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]>
  • Loading branch information
averissimo and chlebowa authored Sep 5, 2023
1 parent 9927221 commit 347f6e8
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
test-strategy: ["min", "release", "max"]
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
secrets:
Expand Down
39 changes: 29 additions & 10 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -16,35 +16,54 @@ Description: Functions for extracting and merging data in the teal
framework.
License: Apache License 2.0 | file LICENSE
Depends:
magrittr,
magrittr (>= 1.5),
R (>= 3.6)
Imports:
checkmate,
dplyr,
lifecycle,
checkmate (>= 2.1.0),
dplyr (>= 1.1.0),
lifecycle (>= 0.2.0),
logger (>= 0.2.0),
methods,
rlang,
shiny,
rlang (>= 1.0.0),
shiny (>= 1.6.0),
shinyjs,
shinyvalidate,
stats,
teal.data (>= 0.3.0),
teal.logger (>= 0.1.1),
teal.slice (>= 0.4.0),
teal.widgets (>= 0.4.0),
tidyr,
tidyr (>= 0.8.3),
tidyselect
Suggests:
knitr,
rmarkdown,
shinytest,
knitr (>= 1.42),
shinytest (>= 1.5.1),
teal.code (>= 0.4.0),
testthat (>= 3.1.5)
VignetteBuilder:
knitr
RdMacros:
lifecycle
Config/Needs/verdepcheck:
tidyverse/magrittr,
mllg/checkmate,
tidyverse/dplyr,
r-lib/lifecycle,
daroczig/logger,
r-lib/rlang,
rstudio/shiny,
daattali/shinyjs,
rstudio/shinyvalidate,
insightsengineering/teal.data,
insightsengineering/teal.logger,
insightsengineering/teal.slice,
insightsengineering/teal.widgets,
tidyverse/tidyr,
r-lib/tidyselect,
yihui/knitr,
rstudio/shinytest,
insightsengineering/teal.code,
r-lib/testthat
Config/Needs/website: insightsengineering/nesttemplate
Encoding: UTF-8
Language: en-US
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# teal.transform 0.4.0.9002

### Miscellaneous

* Specified minimal version of package dependencies.

# teal.transform 0.4.0

### Miscellaneous
Expand Down

0 comments on commit 347f6e8

Please sign in to comment.