Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append testthat prefix in tests #249

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Append testthat prefix in tests #249

merged 5 commits into from
Jan 25, 2024

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 23, 2024

🥇

@m7pr m7pr added the core label Jan 23, 2024
Copy link
Contributor

github-actions bot commented Jan 23, 2024

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  --------------
R/tm_g_ae_oview.R             252     252  0.00%    83-368
R/tm_g_ae_sub.R               315     315  0.00%    59-410
R/tm_g_butterfly.R            388     388  0.00%    124-552
R/tm_g_decorate.R              46      46  0.00%    18-98
R/tm_g_events_term_id.R       299     299  0.00%    63-400
R/tm_g_heat_bygrade.R         321     321  0.00%    135-492
R/tm_g_patient_profile.R      711     711  0.00%    159-935
R/tm_g_spiderplot.R           324     324  0.00%    99-468
R/tm_g_swimlane.R             378     378  0.00%    125-560
R/tm_g_waterfall.R            427     427  0.00%    108-586
R/utils.R                      37      32  13.51%   32-91, 124-131
R/zzz.R                         1       1  0.00%    2
TOTAL                        3499    3494  0.14%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: dcfa5b3

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jan 23, 2024

Unit Tests Summary

 1 files   1 suites   0s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
13 runs  13 ✅ 0 💤 0 ❌

Results for commit dcfa5b3.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected the lintr issue and bumped {testthat} to a working version common with others.

Even 3.0.4 does not work on my machine, so played it safe with 3.1.5

image

@chlebowa
Copy link
Contributor

Even 3.0.4 does not work on my machine, so played it safe with 3.1.5

Just make sure our CI can keep up 😉

@averissimo
Copy link
Contributor

True, but it's going up to the same version as other packages (that need support for the expect_no_error)

Such as {teal}. This shouldn't cause problems

image

@m7pr m7pr merged commit 989f5d1 into main Jan 25, 2024
24 checks passed
@m7pr m7pr deleted the append_testthat@main branch January 25, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants