Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds min package version #222

Merged
merged 8 commits into from
Apr 8, 2024
Merged

Adds min package version #222

merged 8 commits into from
Apr 8, 2024

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Jul 26, 2023

WIP :: parent issue: insightsengineering/nestdevs-tasks#7

Supersede:

🔴 What's needed before merging?

This PR depends on some upstream changes that need to be finalized/merged before being ready to review.

Change in code

  • verdepcheck.yml action (see comments)
    • Remove on: push section
    • Change branch to main

PRS

Changes description

  • Adds minimum version for packages DESCRIPTION
  • Adds Config/Need/verdepcheck section in DESCRIPTION
  • Updates verdepcheck action

@averissimo
Copy link
Contributor Author

Blocked until {teal.slice} is released in CRAN as they are secondary depedencies of {teal} that {verdepcheck} cannot find otherwise

@pawelru pawelru marked this pull request as ready for review April 8, 2024 15:16
@pawelru
Copy link
Contributor

pawelru commented Apr 8, 2024

undrafting and approving this - all is green

@pawelru pawelru removed the blocked label Apr 8, 2024
@pawelru pawelru self-assigned this Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  --------------
R/tm_g_ae_oview.R             252     252  0.00%    83-368
R/tm_g_ae_sub.R               315     315  0.00%    59-410
R/tm_g_butterfly.R            388     388  0.00%    124-552
R/tm_g_decorate.R              46      46  0.00%    18-98
R/tm_g_events_term_id.R       299     299  0.00%    63-400
R/tm_g_heat_bygrade.R         322     322  0.00%    135-493
R/tm_g_patient_profile.R      711     711  0.00%    157-933
R/tm_g_spiderplot.R           324     324  0.00%    99-468
R/tm_g_swimlane.R             376     376  0.00%    124-557
R/tm_g_waterfall.R            427     427  0.00%    108-586
R/utils.R                      37      32  13.51%   32-91, 124-131
R/zzz.R                         2       2  0.00%    2-3
TOTAL                        3499    3494  0.14%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 74837ab

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Unit Tests Summary

 1 files   1 suites   0s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
13 runs  13 ✅ 0 💤 0 ❌

Results for commit 74837ab.

♻️ This comment has been updated with latest results.

@pawelru pawelru merged commit 375c92b into main Apr 8, 2024
25 checks passed
@pawelru pawelru deleted the verdepcheck_action branch April 8, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants