Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vignette changes #687

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Vignette changes #687

merged 3 commits into from
Feb 27, 2024

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Feb 27, 2024

Closes #640

@vedhav vedhav added documentation Improvements or additions to documentation core labels Feb 27, 2024
@vedhav vedhav changed the base branch from vignettes_review@pre-release@main to pre-release@main February 27, 2024 06:35
@vedhav vedhav changed the base branch from pre-release@main to vignettes_review@pre-release@main February 27, 2024 06:35
kartikeyakirar
kartikeyakirar approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@kartikeyakirar kartikeyakirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. 🚀

@kartikeyakirar kartikeyakirar self-assigned this Feb 27, 2024
@vedhav vedhav merged commit 1fae848 into vignettes_review@pre-release@main Feb 27, 2024
@vedhav vedhav deleted the 640-vignette-changes@pre-release@main branch February 27, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartikeyakirar kartikeyakirar kartikeyakirar approved these changes

Assignees

@kartikeyakirar kartikeyakirar

Labels
core documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vedhav @kartikeyakirar