Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-release tm_g_response document update #666

Merged
merged 10 commits into from
Feb 26, 2024

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Feb 21, 2024

part of #624

blocked by #651

@averissimo averissimo force-pushed the tm_g_response@pre-release@main branch from db75f8c to ffeec54 Compare February 22, 2024 13:39
@averissimo averissimo marked this pull request as ready for review February 22, 2024 13:39
@vedhav vedhav self-assigned this Feb 26, 2024
Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments from me. Other than that LGTM.

I see that the vignettes do not have the author as "NEST CoreDev". Out of scope for this PR, I'll send another small PR for this.

R/tm_g_response.R Outdated Show resolved Hide resolved
R/tm_g_response.R Outdated Show resolved Hide resolved
@m7pr
Copy link
Contributor

m7pr commented Feb 26, 2024

@averissimo I think you are good merging this one.

@averissimo averissimo merged commit cb07cce into pre-release@main Feb 26, 2024
@averissimo averissimo deleted the tm_g_response@pre-release@main branch February 26, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants