Add two example apps to showcase DDL and Custom transformation #177
Conversation
Co-authored-by: Dawid Kałędkowski <[email protected]> Signed-off-by: Vedha Viyash <[email protected]>
Co-authored-by: Dawid Kałędkowski <[email protected]> Signed-off-by: Vedha Viyash <[email protected]>
Co-authored-by: Dawid Kałędkowski <[email protected]> Signed-off-by: Vedha Viyash <[email protected]>
vedhav
force-pushed
the
669_insertUI@dev
branch
from
184dd46 to
929f2df
Compare
| @@ -78,7 +93,7 @@ jobs: | |||
| - name: Checkout repo 🛎 | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| ref: "${{ env.BRANCH_NAME }}" | |||
| ref: "669_insertUI@dev" | |||
There was a problem hiding this comment.
| ref: "669_insertUI@dev" | |
| ref: "${{ env.BRANCH_NAME }}" |
Should revert the branch checkout before merging. This was changed just to test the deployment.
vedhav
force-pushed
the
669_insertUI@dev
branch
from
a57d8fc to
91d4179
Compare
vedhav
force-pushed
the
669_insertUI@dev
branch
from
5fc88d1 to
563be2e
Compare
|
Both the custom-transform and delayed-data apps are deployed on |
|
@vedhav Is it possible to make the output of the custom-transform a bit more customized so that the output panel is more insightful when merging |
|
Sure @kumamiao, thanks for the idea!
2. Do you want to sort the column names for select options or leave them in the same order as the datasets?
|
| CO2[factors] <- lapply(CO2[factors], as.character) | ||
| }) | ||
| join_keys(data) <- default_cdisc_join_keys[c("ADSL", "ADTTE")] | ||
| teal.data::datanames(data) <- c("ADSL", "ADTTE", "iris", "CO2") |
| filters <- teal_slices( | ||
| teal_slice(dataname = "mtcars", varname = "gear", multiple = FALSE), | ||
| teal_slice(dataname = "iris", varname = "Species"), | ||
| teal_slice(dataname = "iris", varname = "Sepal.Length"), | ||
| teal_slice( | ||
| dataname = "iris", varname = "Species3", | ||
| fixed = TRUE, anchored = FALSE | ||
| ), | ||
| teal_slice( | ||
| dataname = "iris", varname = "Species4", | ||
| fixed = FALSE, anchored = TRUE, multiple = TRUE | ||
| ), | ||
| teal_slice( | ||
| dataname = "iris", varname = "Species5", | ||
| fixed = TRUE, anchored = TRUE | ||
| ), | ||
| teal_slice( | ||
| dataname = "iris", id = "custom_expr", title = "Custom Expression", | ||
| expr = "Sepal.Width > 2.5 & Petal.Length > 1.5", | ||
| ) | ||
| ) |
There was a problem hiding this comment.
I think filters in context of ddl are irrelevant. There are no filters in custom-transform app you've proposed in this PR and they are comparably irrelevant in both cases. I'd focus on specific functionality rather than showing combination of them - combination is showcased in apps like efficacy or others.
Adds
delayed-dataandcustom-transformapp.Note that it will take a while for this branch to be merged to the main depending on the release of the
teal_transform_modulefeature.Additionally, after the UI-refactor the apps have to be re-recorded.