Skip to content

Commit

Permalink
Adds min package version (#158)
Browse files Browse the repository at this point in the history
WIP :: parent issue:
insightsengineering/nestdevs-tasks#7

Supersede:
* #148

### 🔴 Checklist for PR Reviewer

- [x] Tag yourself next to this repo on
insightsengineering/nestdevs-tasks#7
- [x] Package versions are the same or higher than `main`
- [x] Package list is the same
  - Only exception is `rmarkdown` (may have been removed on `Suggests`)
- [x] All packages in `Imports`, `Depends` & `Suggests` are in new
section `Config/Needs/verdepcheck`
- [x] Added entry to `NEWS.md`
- [x] Last `scheduled.yaml` action was run succesfully _(all 4
strategies)_
- important: it's not the last commit, it's the one that runs 4
`Scheduled 🕰️ / Dependency` actions
- [x] `scheduled.yaml` SHOULD NOT have any push on any branches

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* `verdepcheck.yml` action (see comments)
  - [x] Remove `on: push` section 
  - [x] Change branch to main

#### PRS

- [x] verdepcheck
  * insightsengineering/verdepcheck#24
  * insightsengineering/verdepcheck#26
- [x] verdepcheck-action
  * insightsengineering/r-verdepcheck-action#16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action

---------

Signed-off-by: André Veríssimo <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]>
  • Loading branch information
averissimo and chlebowa authored Sep 5, 2023
1 parent dfd5d97 commit 84e8049
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
test-strategy: ["min", "release", "max"]
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
secrets:
Expand Down
46 changes: 34 additions & 12 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -17,36 +17,58 @@ Description: Data Model for `teal` Applications.
License: Apache License 2.0 | file LICENSE
Depends:
R (>= 4.0),
shiny
shiny (>= 1.6.0)
Imports:
checkmate,
checkmate (>= 2.1.0),
digest,
lifecycle,
lifecycle (>= 0.2.0),
logger (>= 0.2.0),
methods,
R6,
rlang,
R6 (>= 2.2.0),
rlang (>= 1.1.0),
shinyjs,
stats,
teal.logger (>= 0.1.1),
utils,
yaml
yaml (>= 1.1.0)
Suggests:
bslib,
dplyr,
knitr,
magrittr,
dplyr (>= 1.1.0),
knitr (>= 1.42),
magrittr (>= 1.5),
MultiAssayExperiment,
readr,
reticulate (>= 1.22),
rmarkdown,
rmarkdown (>= 2.19),
SummarizedExperiment,
testthat (>= 2.0),
withr
testthat (>= 3.0.4),
withr (>= 2.1.0)
VignetteBuilder:
knitr
RdMacros:
lifecycle
Config/Needs/verdepcheck:
rstudio/shiny,
mllg/checkmate,
eddelbuettel/digest,
r-lib/lifecycle,
daroczig/logger,
r-lib/R6,
r-lib/rlang,
daattali/shinyjs,
insightsengineering/teal.logger,
yaml=vubiostat/r-yaml,
rstudio/bslib,
tidyverse/dplyr,
yihui/knitr,
tidyverse/magrittr,
MultiAssayExperiment,
tidyverse/readr,
rstudio/reticulate,
rstudio/rmarkdown,
SummarizedExperiment,
r-lib/testthat,
r-lib/withr
Config/Needs/website: insightsengineering/nesttemplate
Encoding: UTF-8
Language: en-US
Expand Down
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# teal.data 0.3.0.9002

### Miscellaneous
* Specified minimal version of package dependencies.

# teal.data 0.3.0

### Enhancements
Expand Down

0 comments on commit 84e8049

Please sign in to comment.