-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specify min deps #104
specify min deps #104
Conversation
Code Coverage Summary
Diff against main
Results for commit: 4b5b0c9 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Hi @walkowif. I looked briefly into the workflow log and please find my comments:
I will have a deeper look tomorrow. |
Unit Test Performance Difference
Results for commit 706f290 ♻️ This comment has been updated with latest results. |
I've checked and running We could split the script but I'm not sure what value this would add and I'm also not sure how to pass the object from step 1. to 2. The check can of course be made non-obligatory until it's tested properly. |
Propagate changes from: insightsengineering/idr-tasks#522, insightsengineering/idr-tasks#533 and insightsengineering/idr-tasks#543. Verdepcheck update (insightsengineering/idr-tasks#513) is added in #104. --------- Co-authored-by: Davide Garolini <[email protected]> Co-authored-by: cicdguy <[email protected]>
Closed in favor of #123 that implements new strategies |
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: * #104 ### 🔴 Checklist for PR Reviewer - [x] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [x] Package versions are the same or higher than `main` - [x] Package list is the same - Only exception is `rmarkdown` (on `Suggests`) - [x] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [x] Added entry to `NEWS.md` - [x] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [x] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --------- Signed-off-by: André Veríssimo <[email protected]> Co-authored-by: Aleksander Chlebowski <[email protected]>
This PR specified minimal version requirement to pass the R CMD CHECK (incl. tests). If it is not specified then it means that it would work with any historical version which I have found not true.
This specification makes R CMD CHECK pass as well as make the installation plan executable. E.g.
[email protected]
works perfectly fine with the codebase but it won't be used as[email protected]
requires[email protected]
so essentially this is the result of truly installed minimal dependencies.