bug fixes and init pagination (#932)

fixes #929 still some things to brew --------- Signed-off-by: Davide Garolini <[email protected]> Signed-off-by: Davide Garolini <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Joe Zhu <[email protected]>
insightsengineering · Sep 20, 2024 · 49fdf5b · 49fdf5b
1 parent 13b95e0
commit 49fdf5b
Show file tree

Hide file tree

Showing 11 changed files with 1,501 additions and 1,126 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -87,6 +87,8 @@ Collate:
     'package.R'
     'tree_accessors.R'
     'tt_afun_utils.R'
+    'tt_as_df.R'
+    'tt_as_flextable.R'
     'tt_compare_tables.R'
     'tt_compatibility.R'
     'tt_dotabulation.R'

diff --git a/NAMESPACE b/NAMESPACE
@@ -181,6 +181,7 @@ export(table_shell_str)
 export(table_structure)
 export(tail)
 export(theme_docx_default)
+export(theme_html_default)
 export(top_left)
 export(top_level_section_div)
 export(tree_children)

diff --git a/NEWS.md b/NEWS.md
@@ -4,17 +4,27 @@
  * Removed `tt` input from `theme_docx_default()` and added internal handling for row classes and number of columns.
  * Reworked padding and spacing in default theme `theme_docx_default()`.
  * Added top left information handling (now bold and bottom aligned).
+ * Now users can add more than one theme to `tt_to_flextable()`, and/or extend themes.
+ * Added default theme for `.html` outputs.
+ * Added parameter `bold_titles` to `tt_to_flextable()` to bold titles.
 
 ### Bug Fixes
  * Fixed `"\n"` newline issues in `as_html` by relying onto output devices for newline handling. Added `expand_newlines = FALSE` default to allow previous behavior.
- * `keep_split_levels` throws now an error if the user requests to keep levels that are not present in data.
+ * `keep_split_levels()` throws now an error if the user requests to keep levels that are not present in data.
+ * Fixed issue with removal of horizontal lines in `tt_as_flextable()` header when title was added.
+ * Fixed multiple counts in header issue when exporting to `flextable`.
+ * Fixed issue with empty cells `""` having larger imposed margins than filled cell. They are transformed into `" "` before rendering.
+ * Fixed issue with borders appearing in `theme_docx_default()` when only one line of column names is present, but top left information is on multiple lines.
 
 ### Miscellaneous
  * Added option to change `sep = "\t"` and set other parameters via `...` parameter propagation in `export_as_tsv`.
  * Grouped split functions documentation into one page with precise descriptions
  of each function and relative examples.
  * Addition of developer's guide vignette about printing methods, specifically `matrix_form` and `toString`.
  * Moved `simple_analysis` into utils file.
+ * Added examples to `theme_docx_default()` showing how to extend the default theme.
+ * Added the possibility to remove internal borders from label rows in `theme_html_default()`.
+ * Split export functions into separate source files. Similarly for test files.
 
 ## rtables 0.6.9
 ### Miscellaneous