Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update, adding new code #20

Merged
merged 20 commits into from
Dec 5, 2024
Merged

update, adding new code #20

merged 20 commits into from
Dec 5, 2024

Conversation

shajoezhu
Copy link
Collaborator

No description provided.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------
R/assert.R                       26      18  30.77%   2, 7, 13, 26-35, 41-45
R/autoslideR_error.R              7       0  100.00%
R/decorate.R                    138      14  89.86%   49, 113, 186, 241-246, 296-309
R/fastdocall.R                   28      13  53.57%   16, 20-21, 32-40, 45-46
R/format_date.R                   9       0  100.00%
R/ft_formats.R                   42       6  85.71%   123-128
R/func_wrapper.R                 36      20  44.44%   18-29, 36-44
R/g_mean_slides.R                55       0  100.00%
R/generate_output.R              57       4  92.98%   78-80, 82
R/helper_functions.R             36       5  86.11%   16-20
R/l_ae_slide.R                   59       0  100.00%
R/log.R                          31       5  83.87%   35-39
R/null_report.R                   4       0  100.00%
R/save_output.R                  58       6  89.66%   73-77, 140, 143-144
R/spec.R                         60      15  75.00%   47-55, 98-99, 127, 131, 139-140, 142-143
R/t_ae_pt_diff_slide.R          122      17  86.07%   34-45, 151, 183-189, 202
R/t_ae_pt_slide.R                18       0  100.00%
R/t_ae_pt_soc_diff_slide.R       17       0  100.00%
R/t_ae_pt_soc_slide.R            17       0  100.00%
R/t_ae_slide.R                   74       0  100.00%
R/t_ae_summary_slide.R          154       0  100.00%
R/t_aesi_slide.R                133       0  100.00%
R/t_dd_slide.R                   23       0  100.00%
R/t_dm_slide.R                   32       0  100.00%
R/t_dor_slide.R                  65       0  100.00%
R/t_ds_slide.R                   52       0  100.00%
R/to_ft_funs.R                  191      42  78.01%   15-101, 113-115, 118, 196, 218, 222, 288-290, 318, 335-339, 357, 369, 377
R/to_slides.R                   143      40  72.03%   55-65, 70, 101-102, 109-112, 129-146, 222-227, 314-320
R/util.R                        301     173  42.52%   54, 69, 106-126, 185-278, 304-316, 359-368, 377-449, 462-465, 469, 475, 483-512, 529-535, 568-571
TOTAL                          1988     378  80.99%

Diff against main

Filename                Stmts    Miss  Cover
--------------------  -------  ------  --------
R/decorate.R                0     -36  +26.09%
R/format_date.R             0      -9  +100.00%
R/ft_formats.R            -12     -30  +52.38%
R/g_mean_slides.R         +55       0  +100.00%
R/helper_functions.R        0     -15  +41.67%
R/l_ae_slide.R            +59       0  +100.00%
R/save_output.R             0      -6  +10.34%
R/t_aesi_slide.R           +1       0  +100.00%
R/t_ds_slide.R            +52       0  +100.00%
R/to_ft_funs.R            -30    -109  +46.34%
R/to_slides.R              +1     -34  +24.14%
R/util.R                   +1      -1  +0.52%
TOTAL                    +127    -240  +14.23%

Results for commit: 9ddb50f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Unit Tests Summary

  1 files   22 suites   2m 14s ⏱️
 51 tests  51 ✅ 0 💤 0 ❌
126 runs  121 ✅ 5 💤 0 ❌

Results for commit 9ddb50f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
bad_filters 👶 $+0.04$ $+1$ $0$ $0$ $0$
filter_spec-verbose 👶 $+0.04$ $+1$ $0$ $0$ $0$
format_date 👶 $+0.26$ $+5$ $0$ $0$ $0$
g_mean_slides 👶 $+0.94$ $+14$ $+5$ $0$ $0$
l_ae_slide 👶 $+8.40$ $+1$ $0$ $0$ $0$
output-table-format 👶 $+3.71$ $+5$ $0$ $0$ $0$
srep_outputs 💔 $6.82$ $+94.47$ $0$ $0$ $0$ $0$
t_ae_pt_diff_slide 💔 $1.72$ $+1.30$ $0$ $0$ $0$ $0$
t_dm_slide 💔 $1.63$ $+1.09$ $0$ $0$ $0$ $0$
t_ds_slide 👶 $+1.53$ $+5$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
bad_filters 👶 $+0.04$ Listing_print_correctly
filter_spec-verbose 👶 $+0.04$ Listing_print_correctly
format_date 👶 $+0.26$ Test_format_date
g_mean_slides 👶 $+0.37$ g_mean_slides_Test_1_Test_graph_creation_of_g_eg_slide_eg_mean_plot_
g_mean_slides 👶 $+0.02$ g_mean_slides_Test_2_Test_error_of_g_eg_slide_
g_mean_slides 👶 $+0.11$ g_mean_slides_Test_3_Test_graph_creation_of_g_lb_slide_lab_mean_plot_
g_mean_slides 👶 $+0.15$ g_mean_slides_Test_4_Test_graph_creation_of_g_lb_slide_lab_change_from_baseline_plot_
g_mean_slides 👶 $+0.02$ g_mean_slides_Test_5_Test_error_of_g_lb_slide_
g_mean_slides 👶 $+0.11$ g_mean_slides_Test_6_Test_graph_creation_of_g_vs_slide_vital_sign_mean_plot_
g_mean_slides 👶 $+0.02$ g_mean_slides_Test_7_Test_error_of_g_vs_slide_
g_mean_slides 👶 $+0.13$ g_mean_slides_Test_8_Test_graph_creation_of_g_mean_slide_vital_sign_mean_plot_
g_mean_slides 👶 $+0.02$ g_mean_slides_Test_9_Test_error_of_general_function_g_mean_slide_
l_ae_slide 👶 $+8.40$ Test_listing_creation_of_l_ae_slide_Adverse_Events_Listing_
output-table-format 👶 $+3.71$ save_an_autoslider_output
srep_outputs 💔 $6.82$ $+94.46$ Listing_print_correctly
t_ae_pt_diff_slide 💔 $1.14$ $+1.22$ Test_table_creation_of_t_ae_pt_slide_safety_summary_table_prune_by_total_2
t_dm_slide 💔 $1.63$ $+1.09$ Test_demographic_table_creation_of_t_dm_slide
t_ds_slide 👶 $+1.53$ Test_table_creation_of_t_ds_slide

Results for commit 4dffc44

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu enabled auto-merge (squash) December 5, 2024 10:59
@shajoezhu shajoezhu disabled auto-merge December 5, 2024 11:40
@shajoezhu shajoezhu enabled auto-merge (squash) December 5, 2024 11:40
@shajoezhu shajoezhu disabled auto-merge December 5, 2024 12:09
@shajoezhu shajoezhu enabled auto-merge (squash) December 5, 2024 13:41
@shajoezhu shajoezhu added the sme label Dec 5, 2024
R/assert.R Show resolved Hide resolved
Copy link

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! We can address the old table code in a different issue :)

@shajoezhu shajoezhu merged commit 78fb192 into main Dec 5, 2024
29 checks passed
@shajoezhu shajoezhu deleted the 16_coverage branch December 5, 2024 23:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants