Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer CD from main #1024

Merged
merged 1 commit into from
Oct 12, 2023
Merged

No longer CD from main #1024

merged 1 commit into from
Oct 12, 2023

Conversation

NSeydoux
Copy link
Contributor

This creates a lot of noise on NPM, making package info harder to read.

@NSeydoux
No longer CD from main
1dccbf5 
This creates a lot of noise on NPM, making package info harder to read.
@NSeydoux NSeydoux marked this pull request as ready for review October 10, 2023 21:47
@NSeydoux NSeydoux requested a review from pmcb55 October 11, 2023 22:22
pmcb55
pmcb55 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@pmcb55 pmcb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've no idea what this is doing exactly, but it 'looks fine' to me.

pmcb55
pmcb55 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@pmcb55 pmcb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmcb55 pmcb55 merged commit 2e86db8 into main Oct 12, 2023
3 checks passed
@pmcb55 pmcb55 deleted the chore/only-cd-on-release branch October 12, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmcb55 pmcb55 pmcb55 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NSeydoux @pmcb55