Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use re-usable release #845

Merged
merged 2 commits into from
Oct 18, 2023
Merged

chore: use re-usable release #845

merged 2 commits into from
Oct 18, 2023

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented Oct 18, 2023

No description provided.

@jeswr jeswr requested a review from a team as a code owner October 18, 2023 10:53
@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solid-client-vc-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 11:09am

@jeswr jeswr enabled auto-merge (squash) October 18, 2023 10:59
Copy link
Contributor

@NSeydoux NSeydoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the .nvmrc ? It has been overlooked when moving to Node 18.

@jeswr jeswr temporarily deployed to ESS PodSpaces October 18, 2023 11:09 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces October 18, 2023 11:09 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces October 18, 2023 11:09 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS Dev-2-2 October 18, 2023 11:09 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces October 18, 2023 11:09 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS Dev-2-2 October 18, 2023 11:09 — with GitHub Actions Inactive
@jeswr jeswr requested a review from NSeydoux October 18, 2023 11:10
Copy link
Contributor

@NSeydoux NSeydoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest we cut a release of this repo to test whether this upgrade worked well. It should only be a transitive dependency of apps depending on @inrupt/solid-client-access-grants, so it will not be disruptive to consumers to cut a patch release, but it would help ensuring this will work for all our repos.

@jeswr jeswr merged commit f27a65c into main Oct 18, 2023
22 checks passed
@jeswr jeswr deleted the chore/reusable-release branch October 18, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants