SDK-3311: Integrate problem details library #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardsph
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
approved these changes
Aug 13, 2024
Comment on lines
+534
to
+537
| mockedFetch = mockedFetchWithResponse( | ||
| 401, | ||
| `{"status": 401, "title": "Unauthorized", "detail": "Example detail"}`, | ||
| { "Content-Type": "application/problem+json" }, |
There was a problem hiding this comment.
Would it be helpful to expose a mock function from the base error library? I reckon we'll do this type of mock for all libraries being integrated.
There was a problem hiding this comment.
Perhaps, although there are probably other common mock functions that could be in a base library but not errors.
Co-authored-by: Zwifi <[email protected]>
edwardsph
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature description
This PR integrates the @inrupt/solid-client-errors library into this code and alters the tests accordingly.
Checklist
index.ts, if applicable..tsfiles) are listed in theexportsfield inpackage.json, if applicable..tsfiles) are listed in thetypedocOptions.entryPointsfield intsconfig.json, if applicable.